462065 - Bad scroll performance on http://en.wikipedia.org/wiki/Main_Page

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Ria Klaassen (not reading all bugmail)]

I discovered this while testing Bug 449357 on trunk, Windows XP.

STR:

Go to the URL, grab the scroll bar, scroll down, and then scroll up.
While scrolling up, you'll see the images double. I tested this only on one computer; I don't know yet if this is also a problem on a faster computer.

This regressed between 20080825031951 and 20080825040024.
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-08-25+01%3A00%3A00&enddate=2008-08-25+05%3A00%3A00

Bug 451028 or Bug 450350 could have caused this and I can't make a choice with one to paste into the blocking field.

Comment 1

[Ria Klaassen (not reading all bugmail)]

No, the scroll speed is quite acceptable on my Vista computer. So it is possibly only a problem on slower systems.

Comment 2

[Martijn Wargers (dead)]

Attachment: background-image needed for testcase

Comment 3

[Martijn Wargers (dead)]

Attachment: testcase

In a 2008-08-23 build, I get as result: 8373ms
In a 2008-08-27 build, I get as result: 25821ms

So there is definitely a performance regression here.

Bug 450350, comment 6 also mentions some urls that mention also showed a scrolling performance regression.

Comment 4

[Martijn Wargers (dead)]

Ria, just always set the blocking1.9? flag for performance regressions, please. Even when you only notice it on slower systems. Performance regressions are very much unwanted, in general.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Is this still bad?

Comment 6

[Bryan]

I'm getting 10828ms using build: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081120 Minefield/3.1b2pre ID:20081120171014

~B

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Bryan, what do you get in Firefox 3 (and 2, if you've got it) on the same machine?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I really want to hear what Martijn's result is with a latest trunk build.

Comment 9

[Martijn Wargers (dead)]

In a 2008-11-24 trunk build, I get as result: 5579ms now.
So this definitely looks fixed to me. Things now look even better than what they used to be, so this is great!
Sorry for the delay.

Comment 10

[Aakash Desai [:aakashd]]

Martijn, can you check across the latest Shiretoko build too. Thanks :)

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED on 1.9.1 build:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2pre) Gecko/20090723 Shiretoko/3.5.2pre (.NET CLR 3.5.30729) ID:20090723050841