Closed Bug 462112 Opened 16 years ago Closed 16 years ago

Bookmarks are not saved

Categories

(Firefox :: Bookmarks & History, defect, P1)

Product:
Firefox
Component:
Bookmarks & History
Platform:
x86
All
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 462366
Milestone:
Firefox 3.5

People

(Reporter: aschultz, Assigned: sdwilsh)

Details

(Keywords: dataloss, relnote, Whiteboard: [needs investigation]) 

User-Agent:       Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1b2pre) Gecko/20081029 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1b2pre) Gecko/20081029 Minefield/3.1b2pre

Since 20081028 nightly, bookmarks are broken (possible on Linux only)

1. bookmarks are lost on restart
2. places.sqlite file from old profile failes to load and breaks UI

Reproducible: Always

Steps to Reproduce:
1. bookmark random page
2. quit firefox, select "Save and Quit"
3. start firefox
Actual Results:  
bookmark is lost

Expected Results:  
book in Bookmarks menu

OS: Ubuntu 8.10
should have mentioneted this, tested with an old and with a new, clean profile
Can you check with the nightly produced today please as well?
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.1b2pre) Gecko/20081029 Minefield/3.1b2pre

mixed results:

- the old profile (places.sqlite) still failes to load, UI broken
- with test profile created yesterday, bookmarks can not be saved
- with new profile from current nightly, bookmarks seem to be ok so far
(In reply to comment #3)
> - with test profile created yesterday, bookmarks can not be saved
Do you mean not saved at all, or not if you quit right after you star it?
(In reply to comment #4)
> (In reply to comment #3)
> > - with test profile created yesterday, bookmarks can not be saved
> Do you mean not saved at all, or not if you quit right after you star it?

not save at all apparently.

I tried this with the profile from yesterday:
 1. open a dozen pages in tabs
 2. for one tab, select Bookmarks from Menu, Bookmark This Page, file under bookmarks menu and confirm with done
 3. checked entry in Bookmarks Menu, it was present
 4. browse a bit more
 5. Quit, with Quit and Save
 6. !!! browser crashes !!! <- this is new
 7. Restart
 8. Entry is gone from Bookmarks

Same procedure with a new profile works
I can confirm this too. Adding live bookmarks and or regular bookmarks work fine, but as soon as I close the browser and re-open they are not displayed.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Anything in the error console?
(In reply to comment #7)
> Anything in the error console?

This one seems to appear when I bookmark a page or add a live bookmark:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]"  nsresult: "0x80004002 (NS_NOINTERFACE)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: no]
Out of curiosity, are you on a single or multi-core machine?
(In reply to comment #9)
> Out of curiosity, are you on a single or multi-core machine?

dual-core

> This one seems to appear when I bookmark a page or add a live bookmark:

I get the same one.

Also, starting with an old places.sqlite results in the following errors in the log:

Error: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: file:///net/amun/home/aschultz/bin32/firefox/components/nsPlacesDBFlush.js :: nsPlacesDBFlush :: line 80"  data: no]
Source File: file:///net/amun/home/aschultz/bin32/firefox/components/nsPlacesDBFlush.js
Line: 80

Error: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: file:///net/amun/home/aschultz/bin32/firefox/components/nsBrowserGlue.js :: bg__initPlaces :: line 389"  data: no]
Source File: file:///net/amun/home/aschultz/bin32/firefox/components/nsBrowserGlue.js
Line: 389

Error: uncaught exception: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: file:///net/amun/home/aschultz/bin32/firefox/modules/utils.js :: anonymous :: line 105"  data: no]

Error: uncaught exception: [Exception... "Component returned failure code: 0x8007000e (NS_ERROR_OUT_OF_MEMORY) [nsIDocShellHistory.useGlobalHistory]"  nsresult: "0x8007000e (NS_ERROR_OUT_OF_MEMORY)"  location: "JS frame :: chrome://browser/content/browser.js :: prepareForStartup :: line 886"  data: no]
The errors Andreas gets seem to indicate a corrupt db.  If you could, open the database in something like sqlite explorer, and run |PRAGMA integrity_check| please.
(In reply to comment #11)
> The errors Andreas gets seem to indicate a corrupt db.  If you could, open the
> database in something like sqlite explorer, and run |PRAGMA integrity_check|
> please.

sqlite thinks it is not corrupt:

~/.mozilla/firefox/m31jhv0k.Minefield$ sqlite3 places.sqlite 
SQLite version 3.5.9                                                              
Enter ".help" for instructions                                                    
sqlite> PRAGMA integrity_check                                                    
   ...> ;
ok       

however firefox generates tons of _identical_ places.sqlite-*.corrupt files durring startup
What does |PRAGMA user_version| say?
The corrupt db issue is likely something else - file a new bug please?

As for the original bug, I've got some try server builds going that might help:
https://build.mozilla.org/tryserver-builds/2008-10-29_11:39-sdwilsh@shawnwilsher.com-try-9e8e5d598ea/
Testing with that is appreciated.
(In reply to comment #9)
> Out of curiosity, are you on a single or multi-core machine?

Quad core, looks like we both use multi-core systems.
For the errors in comment 10, bug 462213 will likely help you
(In reply to comment #14)

> Testing with that is appreciated.

Tried that build.

The Error Console shows no errors when bookmarking a page, but the Bookmark is still lost after restart.

Don't know if it is important, but my profile path is NFS4 mounted
(In reply to comment #13)
> What does |PRAGMA user_version| say?

sqlite> PRAGMA user_version;
8
I experienced this and I'm not on multi-core

Not sure if it's related
- places.sqlite bloated to 3 times it's original size (500KB to 1.6MB)
- bookmarks JSON backup file dropped in size (60KB to 7KB)
history are not saved, too.
# it is detaloss bug?

however, New profile can it(bookmarks/history).
Firefox/20081101-trunk/WinXP
Version: unspecified → Trunk
Assignee: nobody → sdwilsh
Flags: blocking-firefox3.1+
Priority: -- → P1
Target Milestone: --- → Firefox 3.1b2
possibly related to bug 462366?
Keywords: dataloss
Anyone seeing this - what is your importBookmarksHTML set to?
Whiteboard: [needs investigation]
Shawn, Dietrich: this doesn't feel like a beta 2 blocker to me, taking it off this list (though leaving bug 462366 on the b2 blocking list for now).
Keywords: relnote
Target Milestone: Firefox 3.1b2 → Firefox 3.1
(In reply to comment #22)
> Anyone seeing this - what is your importBookmarksHTML set to?

You mean the browser.places.importBookmarksHTML pref, right?
I had set it to true. After I've set it to false, the bookmarks were saved again. Thanks for that, it was getting really annoying. Not sure how/why this pref was set to true, though.
(In reply to comment #24)
> You mean the browser.places.importBookmarksHTML pref, right?
> I had set it to true. After I've set it to false, the bookmarks were saved

exactly, we'd like to know how many users have that set to true, since it's causing a problem like this. Setting it to false will solve the issue (if applicable)
Based on comment 24, I'm going to mark this as a dupe of bug 462366
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
Flags: blocking-firefox3.1+
Target Milestone: Firefox 3.1 → Firefox 3.5
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.