462145 - Write a BuildFactory containing all the necessary steps to run our update verification tests

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Comment 1

[[e-mail] (:bhearsum)]

Attachment: buildbot factory for running update verify

This follows the same procedure the Bootstrap patch is bug 462143 does. It also factors generating the URL for shipped-locales and simple logic for ssh keys to ReleaseFactory.

I had to create a very basic UpdateVerify step because we can't rely on return codes to decide success and failure. I purposely did not override __init__ or set any variables to keep it as simple as possible. The idea is the caller should treat it as a ShellCommand.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: [checked in] same as before, without typos

Sadly, I forgot to run this through 'checkconfig' first. Here's a version without the syntax errors.

(Sorry for all the churn.)

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 346915 [details] [diff] [review]
[checked in] same as before, without typos

>diff -r 22f6dd504d34 process/factory.py
...
>+from buildbotcustom.steps.release import UpdateVerify

Need to do the import & reload trick for this too ? Change it if you need to on checkin.

>+class UpdateVerifyFactory(ReleaseFactory):
>+    def __init__(self, mozillaCentral, cvsroot, buildTools, patcherToolsTag,
>+                 hgUsername, baseTag, appName, platform, productName,
>+                 oldVersion, oldBuildNumber, version, buildNumber, ausServerUrl,
>+                 stagingServer, verifyConfig, oldAppVersion=None,
>+                 appVersion=None, hgSshKey=None):
>+        ReleaseFactory.__init__(self)

Hmm, in Bootstrap we must have a version, which is the RelEng friendly name of the release we're working on, and can have an appVersion if the version used inside the app is different. There are matching old vars, eg
  version         = 3.0rc3
  appVersion      = 3.0
  oldVersion      = 3.0rc2
  oldAppVersion   = 3.0

The vars in this class seem to match up with that, but the config uses appVersion as version. I'd like to resolve that confusion before the rc's come along.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to comment #3)
> (From update of attachment 346915 [details] [diff] [review])
> >diff -r 22f6dd504d34 process/factory.py
> ...
> >+from buildbotcustom.steps.release import UpdateVerify
> 
> Need to do the import & reload trick for this too ? Change it if you need to on
> checkin.
> 

Yeah, good point.

> The vars in this class seem to match up with that, but the config uses
> appVersion as version. I'd like to resolve that confusion before the rc's come
> along.

I filed bug 464014. I'll make sure someone takes this on well before RC1.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 346915 [details] [diff] [review]
[checked in] same as before, without typos

checked in w/ import/reload for buildbotcustom.steps.release)

Checking in process/factory.py;
/cvsroot/mozilla/tools/buildbotcustom/process/factory.py,v  <--  factory.py
new revision: 1.32; previous revision: 1.31
done
RCS file: /cvsroot/mozilla/tools/buildbotcustom/steps/release.py,v
done
Checking in steps/release.py;
/cvsroot/mozilla/tools/buildbotcustom/steps/release.py,v  <--  release.py
initial revision: 1.1
done