462200 - wrong names for access keys introduced by Bug 459413

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Adrian Kalla [:adriank]]

(this is the SeaMonkey part of bug 462199)

The bug 459413 introduced this new entities in
notification.properties:

+geolocation.exactLocation=Exact Location (within 10 feet)
+geolocation.exactLocationKey=E
+geolocation.neighborhoodLocation=Neighborhood (within 1 mile)
+geolocation.neighborhoodLocationKey=N
+geolocation.nothingLocation=Nothing
+geolocation.nothingLocationKey=o

Unfortunately, our l10n tools like compare-locales or the translate toolkit do
not recognize entities of the form *Key as access keys, so this names needs to
be changed to e.g. *AccessKey .

Comment 1

[Robert Kaiser]

Hmm, right. I should have noticed that.

We might want to follow bug 462199 comment #1 here.

Comment 2

[Robert Kaiser]

Attachment: change geolocation prompt to more L10n-sane .label/.accesskey

This patch changes us to use more L10n-sane .label/.accesskey.

Comment 3

[[e-mail]]

Comment on attachment 345375 [details] [diff] [review]
change geolocation prompt to more L10n-sane .label/.accesskey

Do the other labels need to be fixed (the ones with no .label suffix, although the access keys still have .accesskey)?

Comment 4

[Robert Kaiser]

Not sure, the tools might know to associate "foo.accesskey" with "foo" as well, actually, even though it's clearer with .label.

We currently have 9 locales that already have those strings, I wonder if we can automatically fix them in some way.

Comment 5

[Robert Kaiser]

pushed as http://hg.mozilla.org/comm-central/rev/d569ce2a343c