Closed Bug 462272 Opened 13 years ago Closed 13 years ago

DTrace broken on trunk

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: Dolske, Assigned: jimb)

Details

(Keywords: verified1.9.1)

Attachments

(2 files)

In file included from mozilla-central/js/src/jsdtracef.c:47:
mozilla-central/js/src/jsdtracef.h:36:30: error: javascript-trace.h: No such file or directory

I normally build with DTrace, but just did a rm -rf on my obj-dir.
Any plan here? A number of other people are being bitten by this, and it obviously makes debugging/profiling difficult.
Flags: blocking1.9.1?
Attached patch patchSplinter Review
This is a problem with dependencies somewhere. This patch fixes it by checking javascript-trace.h is built and up to date in the export phase. I'm not totally sure it is the right way to do it but it works. Not really sure who is best to review this.
Assignee: jim → dtownsend
Status: NEW → ASSIGNED
Attachment #347158 - Flags: review?(mrbkap)
Comment on attachment 347158 [details] [diff] [review]
patch

I'm really not the right person to review this.
Attachment #347158 - Flags: review?(mrbkap) → review?(jim)
Record object files' dependency on javascript-trace.h, when
HAVE_DTRACE is set.

Use $(CURDIR) where javascript-trace.h appears as a target or
dependency, to ensure that VPATH doesn't cause us to use a copy other
than the one in the object directory.
Attachment #347672 - Flags: review?(mrbkap)
Does this work as well?  That's more analogous to the approach used above for jsautokw.h and jsautooplen.h, above.
Attachment #347158 - Flags: review?(jim) → review-
Attachment #347672 - Flags: review?(mrbkap) → review+
Thanks, Blake!  Just waiting for a confirmation from Dave or Justin that attachment 347672 [details] [diff] [review] also works for them.
Works for me
Assignee: dtownsend → jim
Whiteboard: checkin-needed
Landed, http://hg.mozilla.org/mozilla-central/rev/d2c374d7b45c.

Leaving open for the owners to actually mark it fixed etc.
Whiteboard: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
My build worked earlier today with it enabled.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Flags: in-litmus-
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
This landed before branching.
Keywords: fixed1.9.1
Keywords: verified1.9.1
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.