462272 - DTrace broken on trunk

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Justin Dolske [:Dolske]]

In file included from mozilla-central/js/src/jsdtracef.c:47:
mozilla-central/js/src/jsdtracef.h:36:30: error: javascript-trace.h: No such file or directory

I normally build with DTrace, but just did a rm -rf on my obj-dir.

Comment 1

[Justin Dolske [:Dolske]]

Any plan here? A number of other people are being bitten by this, and it obviously makes debugging/profiling difficult.

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch

This is a problem with dependencies somewhere. This patch fixes it by checking javascript-trace.h is built and up to date in the export phase. I'm not totally sure it is the right way to do it but it works. Not really sure who is best to review this.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 347158 [details] [diff] [review]
patch

I'm really not the right person to review this.

Comment 4

[Jim Blandy :jimb]

Attachment: Bug 462272: Record dependency on generated header javascript-trace.h

Record object files' dependency on javascript-trace.h, when
HAVE_DTRACE is set.

Use $(CURDIR) where javascript-trace.h appears as a target or
dependency, to ensure that VPATH doesn't cause us to use a copy other
than the one in the object directory.

Comment 5

[Jim Blandy :jimb]

Does this work as well?  That's more analogous to the approach used above for jsautokw.h and jsautooplen.h, above.

Comment 6

[Jim Blandy :jimb]

Thanks, Blake!  Just waiting for a confirmation from Dave or Justin that attachment 347672 [details] [diff] [review] also works for them.

Comment 7

[Dave Townsend [:mossop]]

Works for me

Comment 8

[Axel Hecht [:Pike]]

Landed, http://hg.mozilla.org/mozilla-central/rev/d2c374d7b45c.

Leaving open for the owners to actually mark it fixed etc.

Comment 9

[Shawn Wilsher :sdwilsh]

My build worked earlier today with it enabled.

Comment 10

[Benjamin Smedberg]

This landed before branching.