462364 - Deleting a List from Address Book does not get reflected immediately

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[DP]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.3) Gecko/2008092414 Firefox/3.0.3
Build Identifier: 3.0b1 pre

When you delete a list, it doesn't disappear from the address book immediately so it looks like delete has failed.  If you do a search for the list, the list no longer appears.

Reproducible: Always

Steps to Reproduce:
1.create a list
2.search for the list
3.delete the list

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix and test

This fixes the bug, the problem was we were sending an item removed notification for the directory representation, but not the card...

Although we're probably splitting these soon, I'd still like to fix this for b1 and get the unit test in.

The unit test is testing more than just the notification here, which means we can hopefully ensure we still get the right updates if/when we change things.

Comment 2

[David :Bienvenu]

Comment on attachment 348549 [details] [diff] [review]
The fix and test

this looks good - I haven't tested it, so I'm relying on the test case being valid.

Did you intend the compose dir changes to be in this diff?

Comment 3

[Mark Banner (:standard8)]

The test case does enough to show the bug is fixed (i.e. we're sending out the notification), but doesn't test nsAbView as that's a bit harder.

The compose changes were intentional and were just included in this patch due to them being small removals of obsolete includes (I checked this was ok with David until after b1).

Checked in: http://hg.mozilla.org/comm-central/rev/f550ece98221