Closed Bug 462373 Opened 18 years ago Closed 18 years ago

Code simplifications

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: cpearce)

Details

Attachments

(1 file, 1 obsolete file)

See bug 448603 comment #17: > >+nsresult nsHTMLMediaElement::PickMediaElement() > > if (HasAttr(kNameSpaceID_None, nsGkAtoms::src)) { > > if (GetAttr(kNameSpaceID_None, nsGkAtoms::src, src)) { > > Why do we do that HasAttr check? > > > const nsAFlatCString &charset = doc->GetDocumentCharacterSet(); > > nsContentUtils::NewURIWithDocumentCharset? Chris P, can you take this?
Assignee: nobody → chris
Status: NEW → ASSIGNED
Attached patch Patch v1 (obsolete) — — Splinter Review
Changes as requested.
Attachment #346147 - Flags: review?(bzbarsky)
Comment on attachment 346147 [details] [diff] [review] Patch v1 Oops, forgot to remove commented out stuff...
Attachment #346147 - Attachment is obsolete: true
Attachment #346147 - Flags: review?(bzbarsky)
Attached patch Patch v1.1 — — Splinter Review
Attachment #346150 - Flags: review?(bzbarsky)
Attachment #346150 - Flags: superreview+
Attachment #346150 - Flags: review?(bzbarsky)
Attachment #346150 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: