Closed Bug 462373 Opened 12 years ago Closed 11 years ago

Code simplifications

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: cpearce)

Details

Attachments

(1 file, 1 obsolete file)

See bug 448603 comment #17:

> >+nsresult nsHTMLMediaElement::PickMediaElement()
> >   if (HasAttr(kNameSpaceID_None, nsGkAtoms::src)) {
> >     if (GetAttr(kNameSpaceID_None, nsGkAtoms::src, src)) {
> 
> Why do we do that HasAttr check?
>
> >   const nsAFlatCString &charset = doc->GetDocumentCharacterSet();
> 
> nsContentUtils::NewURIWithDocumentCharset?

Chris P, can you take this?
Assignee: nobody → chris
Status: NEW → ASSIGNED
Attached patch Patch v1 (obsolete) — Splinter Review
Changes as requested.
Attachment #346147 - Flags: review?(bzbarsky)
Comment on attachment 346147 [details] [diff] [review]
Patch v1

Oops, forgot to remove commented out stuff...
Attachment #346147 - Attachment is obsolete: true
Attachment #346147 - Flags: review?(bzbarsky)
Attached patch Patch v1.1Splinter Review
Attachment #346150 - Flags: review?(bzbarsky)
Attachment #346150 - Flags: superreview+
Attachment #346150 - Flags: review?(bzbarsky)
Attachment #346150 - Flags: review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.