Closed
Bug 462373
Opened 18 years ago
Closed 18 years ago
Code simplifications
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: cpearce)
Details
Attachments
(1 file, 1 obsolete file)
|
3.48 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
See bug 448603 comment #17:
> >+nsresult nsHTMLMediaElement::PickMediaElement()
> > if (HasAttr(kNameSpaceID_None, nsGkAtoms::src)) {
> > if (GetAttr(kNameSpaceID_None, nsGkAtoms::src, src)) {
>
> Why do we do that HasAttr check?
>
> > const nsAFlatCString &charset = doc->GetDocumentCharacterSet();
>
> nsContentUtils::NewURIWithDocumentCharset?
Chris P, can you take this?
| Assignee | ||
Updated•18 years ago
|
Assignee: nobody → chris
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•18 years ago
|
||
Changes as requested.
Attachment #346147 -
Flags: review?(bzbarsky)
| Assignee | ||
Comment 2•18 years ago
|
||
Comment on attachment 346147 [details] [diff] [review]
Patch v1
Oops, forgot to remove commented out stuff...
Attachment #346147 -
Attachment is obsolete: true
Attachment #346147 -
Flags: review?(bzbarsky)
| Assignee | ||
Comment 3•18 years ago
|
||
Attachment #346150 -
Flags: review?(bzbarsky)
Updated•18 years ago
|
Attachment #346150 -
Flags: superreview+
Attachment #346150 -
Flags: review?(bzbarsky)
Attachment #346150 -
Flags: review+
| Assignee | ||
Updated•18 years ago
|
Keywords: checkin-needed
Comment 4•18 years ago
|
||
Keywords: checkin-needed
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•