462412 - API for destroying fragments

Status: VERIFIED WORKSFORME

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), enhancement)

Description

[David Mandelin [:dmandelin]]

In the regex world, memory management of fragments is relatively simple, because they belong to individual JSRegExp objects, so I'd like to be able to just delete the owned fragments when the regex is gc'd. But there's currently no API in Fragmento for doing this.

There is an alternative of nuking all the fragments when gc occurs and rematerializing when needed, but I like this way better as the perf should be better and, more importantly, it seems more bug-avoidant.

Comment 1

[David Mandelin [:dmandelin]]

Attachment: Patch

Comment 2

[Andreas Gal :gal]

Comment on attachment 345822 [details] [diff] [review]
Patch

David, is it safe to destroy fragments like that? What about the lirbuf?

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 345822 [details] [diff] [review]
Patch

There wasn't such a function before because lirbuffers could be shared across unrelated fragments.  Even if you don't cause that to happen, having the API call sort of exposes the dependency problem.

I'd put a big warning that the fragment's lirbuf can be shared and it's the user's responsibility to track dependencies.

Comment 4

[Edwin Smith]

looks like this has been done for a long time now.  reopen if it needs to track a more specific problem.