462427 - CROSS_COMPILE should not be required when cross compiling

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Doug Turner (:dougt)]

in our mozconfig, in order to build from windows 32 to windows ce, it is required that we set:

CROSS_COMPILE = 1

However, it appears that this flag is superficial and autoconf already can tell if you are cross compiling based on the target and host flags.

Furthermore, code in configure.in, such as:

http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#215

is not being executed.

We should clean this up, and not required CROSS_COMPILE to be defined and simply determine if we are cross compiling based on the target being set.

Comment 1

[Mike Hommey [:glandium]]

Turns out I'm backslapped by this in bug 969164 because of how poorly we're subconfiguring libffi. It turns out js/src is already setting CROSS_COMPILE=1 semi-automatically, so that makes libffi happy by chance, and moving libffi subconfigure to top-level breaks the charm. So, might as well do the right thing with CROSS_COMPILE.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Stop requiring CROSS_COMPILE being set

https://tbpl.mozilla.org/?tree=Try&rev=05e93b3ebaa8

Comment 3

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #2)
> Created attachment 8372184 [details] [diff] [review]
> Stop requiring CROSS_COMPILE being set
> 
> https://tbpl.mozilla.org/?tree=Try&rev=05e93b3ebaa8

A note: this patch also makes us stop pretending that the linux 32 bits are cross compiles when in fact, they aren't because we build both host and target stuff with gcc -m32.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01de43f70bed

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/01de43f70bed