462470 - TM: js1_7/block/regress-352609.js FAIL

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

tracemonkey

p = {}; (p.z = let(x) x)() reason: 

Expected match to 
'/TypeError: (p.z = \(let \(x\) x\)|.*Undefined.*) is not a function/', 

Actual value 
'TypeError: p.z = let (x) x is not a function'

regressed by http://hg.mozilla.org/tracemonkey/rev/4702f17a8589
bug 461233

Comment 1

[Bob Clary [:bc] (inactive)]

ditto js1_7/decompilation/regress-349602.js

Expected value 
' function ( ) { ( let ( a = 3 ) <x/> ) ; } ', 

Actual value 
' function ( ) { let ( a = 3 ) <x/>; } '

Comment 2

[Bob Clary [:bc] (inactive)]

ditto js1_7/decompilation/regress-352011.js

Expected value 
' function ( ) { ( let ( x ) ( { t : x } ) ) ; } ', 

Actual value 
' function ( ) { let ( x ) ( { t : x } ) ; } '


js1_7/decompilation/regress-352022.js

Expected value 
' function ( ) { g ( h ) = ( ( let ( y ) 3 ) , true ) ; } ', 

Actual value 
' function ( ) { g ( h ) = ( let ( y ) 3 , true ) ; } '

js1_7/extensions/regress-353249.js

Expected value 
' function ( ) { ( let ( x ) <x/> . ( ( 1 ) ) < ( let ( z ) eval ( " 3 " ) ) ) ; for ( x in this ) { } } ', 

Actual value 
' function ( ) { let ( x ) <x/> . ( ( 1 ) ) < ( let ( z ) eval ( " 3 " ) ) ; for ( x in this ) { } } '

js1_7/regress/regress-420399.js

Expected match to 
'/TypeError: \(let \(a = undefined\) a\) (is undefined|has no properties)/', 

Actual value 
'TypeError: let (a = undefined) a is undefined'

jorendorff already flagged these. my bad again.

Comment 3

[Bob Clary [:bc] (inactive)]

js1_8_1/decompilation/regress-349605.js

Expected value 
' function ( ) { alert ( 1 ) ; for ( ( let ( y = 3 ) ( let ( y = 4 ) y ) ) ; false ; x ++ ) { } alert ( 6 ) ; } ', 

Actual value 
' function ( ) { alert ( 1 ) ; for ( let ( y = 3 ) let ( y = 4 ) y ; false ; x ++ ) { } alert ( 6 ) ; } '

js1_8_1/decompilation/regress-352026.js

Expected value 
' function ( ) { ( let ( s = 4 ) ( { foo : " bar " } ) ) ; } ', 

Actual value 
' function ( ) { let ( s = 4 ) ( { foo : " bar " } ) ; } '

js1_8_1/decompilation/regress-380237-03.js

Expected value 
' function ( ) { ( [ yield ] for ( x in [ ] ) ) ; } ', 

Actual value 
' function ( ) { ( [ ( yield ) ] for ( x in [ ] ) ) ; } '

Comment 4

[Bob Clary [:bc] (inactive)]

also 

js1_7/decompilation/regress-350991.js

Expected value ' function ( ) { for ( ( let ( y ) 3 ) ;; ) { } } ', 
Actual value   ' function ( ) { for ( let ( y ) 3 ;; ) { } } '

Comment 5

[Robert Sayre]

bc, why is this assigned to you?

Comment 6

[Bob Clary [:bc] (inactive)]

these are tests that require modifications.

Comment 7

[Bob Clary [:bc] (inactive)]

Attachment: patch

jorendorff, the second part of js1_8_1/decompilation/regress-350991.js still fails with 

Expected value 
' function ( ) { let x = 5 ; while ( x -- > 0 ) { for ( let x = x , q = 5 ;; ) { } } } ', 

Actual value 
' function ( ) { var x = 5 ; while ( x -- > 0 ) { for ( let x = x , q = 5 ;; ) { } } } '

should the test be changed?

Comment 8

[Bob Clary [:bc] (inactive)]

Checking in spidermonkey-n-1.9.1.tests;
/cvsroot/mozilla/js/tests/spidermonkey-n-1.9.1.tests,v  <--  spidermonkey-n-1.9.1.tests
new revision: 1.8; previous revision: 1.7
done
RCS file: /cvsroot/mozilla/js/tests/js1_8_1/regress/browser.js,v
done
Checking in js1_8_1/regress/browser.js;
/cvsroot/mozilla/js/tests/js1_8_1/regress/browser.js,v  <--  browser.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_8_1/regress/shell.js,v
done
Checking in js1_8_1/regress/shell.js;
/cvsroot/mozilla/js/tests/js1_8_1/regress/shell.js,v  <--  shell.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_8_1/regress/regress-420399.js,v
done
Checking in js1_8_1/regress/regress-420399.js;
/cvsroot/mozilla/js/tests/js1_8_1/regress/regress-420399.js,v  <--  regress-420399.js
initial revision: 1.1
done
Checking in js1_7/decompilation/regress-352022.js;
/cvsroot/mozilla/js/tests/js1_7/decompilation/regress-352022.js,v  <--  regress-352022.js
new revision: 1.3; previous revision: 1.2
done
Checking in js1_8_1/decompilation/regress-349605.js;
/cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-349605.js,v  <--  regress-349605.js
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-350991.js,v
done
Checking in js1_8_1/decompilation/regress-350991.js;
/cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-350991.js,v  <--  regress-350991.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-352011.js,v
done
Checking in js1_8_1/decompilation/regress-352011.js;
/cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-352011.js,v  <--  regress-352011.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-352022.js,v
done
Checking in js1_8_1/decompilation/regress-352022.js;
/cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-352022.js,v  <--  regress-352022.js
initial revision: 1.1
done
Checking in js1_8_1/decompilation/regress-352026.js;
/cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-352026.js,v  <--  regress-352026.js
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-352609.js,v
done
Checking in js1_8_1/decompilation/regress-352609.js;
/cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-352609.js,v  <--  regress-352609.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-353249.js,v
done
Checking in js1_8_1/decompilation/regress-353249.js;
/cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-353249.js,v  <--  regress-353249.js
initial revision: 1.1
done

Comment 9

[Bob Clary [:bc] (inactive)]

missed one:

Checking in regress-380237-03.js;
/cvsroot/mozilla/js/tests/js1_8_1/decompilation/regress-380237-03.js,v  <--  regress-380237-03.js
new revision: 1.2; previous revision: 1.1

Comment 10

[Jason Orendorff [:jorendorff]]

Comment on attachment 349415 [details] [diff] [review]
patch

Thanks, bc.

Comment 11

[Jason Orendorff [:jorendorff]]

(In reply to comment #7)
> jorendorff, the second part of js1_8_1/decompilation/regress-350991.js still
> fails with 
> 
> Expected value 
> ' function ( ) { let x = 5 ; ...
> Actual value 
> ' function ( ) { var x = 5 ; ...
> 
> should the test be changed?

Yes.

Comment 12

[Bob Clary [:bc] (inactive)]

test modified http://hg.mozilla.org/mozilla-central/rev/61dc0838c243 and cvs

Comment 13

[Bob Clary [:bc] (inactive)]

update spidermonkey-n-1.9.1.tests http://hg.mozilla.org/mozilla-central/rev/9db112e7fa33 and cvs