Closed Bug 462490 Opened 11 years ago Closed 11 years ago

Today pane -> 'new event' icon is defect

Categories

(Calendar :: Lightning Only, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: andreas.treumann, Assigned: Fallen)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached image defect 'new event' icon
STEPS TO REPRODUCE:
===================

- install lightning build 20081030062610
- open the today pane

RESULT:
=======

- the 'new event' icon is defect (see screenshot)

EXPECTED RESULT:
================

- only one icon should be visible

REPRODUCIBLE:
=============

- always
defect in build 20081030062610
last build without this issue: 2008102902559
Bug 456377 removed all styling for that button from Lightning.
Blocks: 456377
Component: Calendar Views → Lightning Only
QA Contact: views → lightning
Flags: blocking-calendar1.0+
Mine
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attached patch Fix - v1Splinter Review
We should get rid of the duplicate ID while we are at it.
Attachment #345958 - Flags: review?(Berend.Cornelius)
(In reply to comment #4)
> Created an attachment (id=345958) [details]
> Fix - v1
> 
> We should get rid of the duplicate ID while we are at it.

The pinstripe/winstripe changes don't seem to match.
I see what you mean now, please pretend the rest of pinstripe also has changed to #todaypane-...
Attachment #345958 - Flags: review?(Berend.Cornelius) → review?(mschroeder)
Comment on attachment 345958 [details] [diff] [review]
Fix - v1

r=mschroeder with the pinstripe changes corrected
Attachment #345958 - Flags: review?(mschroeder) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c73d43a0de7c>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Verified fixed using Lightning 1.0pre (20081105045801) with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081105 Shredder/3.0b1pre.
Status: RESOLVED → VERIFIED
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.