462490 - Today pane -> 'new event' icon is defect

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Andreas Treumann]

Attachment: defect 'new event' icon

STEPS TO REPRODUCE:
===================

- install lightning build 20081030062610
- open the today pane

RESULT:
=======

- the 'new event' icon is defect (see screenshot)

EXPECTED RESULT:
================

- only one icon should be visible

REPRODUCIBLE:
=============

- always

Comment 1

[Andreas Treumann]

defect in build 20081030062610
last build without this issue: 2008102902559

Comment 2

[Stefan Sitter [:ssitter]]

Bug 456377 removed all styling for that button from Lightning.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Mine

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v1

We should get rid of the duplicate ID while we are at it.

Comment 5

[Martin Schröder [:mschroeder]]

(In reply to comment #4)
> Created an attachment (id=345958) [details]
> Fix - v1
> 
> We should get rid of the duplicate ID while we are at it.

The pinstripe/winstripe changes don't seem to match.

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

This is intentional, the images are a bit different. Compare: 

http://mxr.mozilla.org/comm-central/source/calendar/sunbird/base/themes/winstripe/toolbar.css#311

and

http://mxr.mozilla.org/comm-central/source/calendar/sunbird/base/themes/pinstripe/toolbar.css#147

Comment 7

[Philipp Kewisch [:Fallen][☁️📆]]

I see what you mean now, please pretend the rest of pinstripe also has changed to #todaypane-...

Comment 8

[Martin Schröder [:mschroeder]]

Comment on attachment 345958 [details] [diff] [review]
Fix - v1

r=mschroeder with the pinstripe changes corrected

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c73d43a0de7c>

-> FIXED

Comment 10

[Stefan Sitter [:ssitter]]

Verified fixed using Lightning 1.0pre (20081105045801) with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081105 Shredder/3.0b1pre.

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".