I turned on -Wextra in the MacOS project file because I need it to diagnose when a "register" variable is being passed by reference or has its address taken - part of the ongoing interpreter cleanup. Doing so turned up one real bug (in StringBuilder.cpp; I guess we're trying to delete that file but until we do it's still a bug) and several silly comparisons, plus a bunch of warnings about non-volatile vars being clobbered by longjmp. I've tidied this up; enclosed. Also in the patch is a change to uniformly turn off C++ exceptions in the Xcode projects. It looks like the configure.py script does this already for release builds. Also in the patch is a change to the VC2008 project files to include WordcodeTranslator.cpp; nobody has noticed the absence because it's not normally needed. (cc'ing Ed & Rick because of a cast inserted in CodegenMIR.cpp.)
Created attachment 345684 [details] [diff] [review] Patch
Attachment #345684 - Flags: review?(stejohns)
Comment on attachment 345684 [details] [diff] [review] Patch I'll never turn down an opportunity to increase warning levels! :-)
Attachment #345684 - Flags: review?(stejohns) → review+
Created attachment 346032 [details] [diff] [review] New patch Resubmitting because I turned on -Wextra for the MMgc project too and also compiled with _DEBUG and DEBUGGER turned on - uncovered more gremlins, unsurprisingly.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.