462495 - [redux] -Wextra and other mop-up work

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Lars T Hansen]

I turned on -Wextra in the MacOS project file because I need it to diagnose when a "register" variable is being passed by reference or has its address taken - part of the ongoing interpreter cleanup.  Doing so turned up one real bug (in StringBuilder.cpp; I guess we're trying to delete that file but until we do it's still a bug) and several silly comparisons, plus a bunch of warnings about non-volatile vars being clobbered by longjmp.  I've tidied this up; enclosed.

Also in the patch is a change to uniformly turn off C++ exceptions in the Xcode projects.  It looks like the configure.py script does this already for release builds.

Also in the patch is a change to the VC2008 project files to include WordcodeTranslator.cpp; nobody has noticed the absence because it's not normally needed.

(cc'ing Ed & Rick because of a cast inserted in CodegenMIR.cpp.)

Comment 1

[Lars T Hansen]

Attachment: Patch

Comment 2

[Steven Johnson]

Comment on attachment 345684 [details] [diff] [review]
Patch

I'll never turn down an opportunity to increase warning levels! :-)

Comment 3

[Lars T Hansen]

Attachment: New patch

Resubmitting because I turned on -Wextra for the MMgc project too and also compiled with _DEBUG and DEBUGGER turned on - uncovered more gremlins, unsurprisingly.

Comment 4

[Lars T Hansen]

tamarin-redux changeset 1049:b0dfe325e005