Closed Bug 462545 Opened 12 years ago Closed 12 years ago

browser_423515.js leaks

Categories

(Firefox :: Bookmarks & History, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: sgautherie, Unassigned)

References

Details

(Keywords: memory-leak)

Attachments

(1 obsolete file)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081031 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)

{
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1356 bytes during test execution (threshold set at 64 bytes)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsNavHistoryContainerResultNode with size 152 bytes each (304 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsNavHistoryFolderResultNode with size 176 bytes each (352 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsNavHistoryQuery with size 104 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsNavHistoryQueryOptions with size 52 bytes each (104 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 1 instance of nsNavHistoryResult with size 144 bytes
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 2 instances of nsNavHistoryResultNode with size 112 bytes each (224 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 12 instances of nsStringBuffer with size 8 bytes each (96 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 4 instances of nsTArray_base with size 4 bytes each (16 bytes total)
TEST-UNEXPECTED-FAIL | runtests-leaks | leaked 3 instances of nsVoidArray with size 4 bytes each (12 bytes total)
}
Flags: wanted-firefox3.1?
Attached patch patch (obsolete) — Splinter Review
i need to give a pass to this with refcount logging, hwv closing containers should be enough
Comment on attachment 346460 [details] [diff] [review]
patch


[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081106 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)

Same leak with this patch :-(
(In reply to comment #2)

The leak is triggered by
|PlacesUtils.tagging.tagURI(this.uri, ["bar"]);|.
(In reply to comment #3)
> (In reply to comment #2)
> 
> The leak is triggered by
> |PlacesUtils.tagging.tagURI(this.uri, ["bar"]);|.

mh true but not completely exact, if you remove the final "PlacesUtils.bookmarks.removeItem(rootId);" the leak does not happen...
tagging service has a node open that has a bookmarks observer, that line is the only one that is using the tagging service so it will open the node. So it could be that we don't close tagging service correctly if the last action involves a bookmarks change notify, tagging node cleanup is done on xpcom-shutdown.
so we could change tagging service to hold a fixed cache and observe bookmarks service for changes, discarding the tagging service open node.
filed Bug 463513 to investigate tagging service change
Depends on: 463513
Blocks: mlkTests
Blocks: 464816
Depends on: 460548
i can't see leaks anymore, Serge?
No longer blocks: 464816
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20081210
Minefield/3.2a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/89a175c70c25)

Bug 463513 fixed this leak.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: wanted-firefox3.1?
Resolution: --- → FIXED
Attachment #346460 - Attachment is obsolete: true
Blocks: 460548
No longer depends on: 460548
verified per comment #8
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.