462568 - Update available prompt never shown if the user restarts without running the app for 12 hours straight

Status: RESOLVED DUPLICATE of bug 534090

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

Found while working on bug 324121 and adding it as a dependency since it should land first.

The code sets a timer that first displays an alert notification and then after 12 hours displays the update ui. If the app is restarted before the 12 hours have elapse (quite likely) then the process starts again by first displaying an alert notification and then after 12 hours displaying the update ui. Anyone that doesn't see the notification or doesn't know what to do with the notification might never know there is an update.

Comment 1

[Dão Gottwald [:dao]]

This isn't an issue with app.update.auto = true, as a restart implies updating, right? In that case, not showing the prompt, except after a long time without a restart (e.g. 12 hours), is by design. We don't even want to remind the user within these 12 hours, I think, in order to make automatic updating smooth and unobtrusive.

Comment 2

[Robert Strong (they/them - no direct email)]

(In reply to comment #1)
> This isn't an issue with app.update.auto = true, as a restart implies updating,
> right?
This is correct except that for major updates we always show the update UI without auto-updating.

Comment 3

[Dão Gottwald [:dao]]

Ok, so what's the right behavior for the non-automatic case? I think the options are:

- show the alert repeatedly
- show the prompt earlier
- don't start counting from zero after a restart
- show the prompt immediately after a restart

Comment 4

[Robert Strong (they/them - no direct email)]

When I discussed this with beltzner we decided it should show the prompt after the 12 hours has elapsed even if there is a restart. It shouldn't display immediately on startup to prevent it from getting in the way of whatever the user is doing and it should use the idleservice as well.

Comment 5

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to comment #5)
> Found while working on bug 324121 and adding it as a dependency since it should
> land first.
> 
> The code sets a timer that first displays an alert notification and then after
> 12 hours displays the update ui. If the app is restarted before the 12 hours
> have elapse (quite likely) then the process starts again by first displaying an
> alert notification and then after 12 hours displaying the update ui. Anyone
> that doesn't see the notification or doesn't know what to do with the
> notification might never know there is an update.

Do you know what versions of FF would have this behavior?
Also, aiui, this is only with users who said "Ask me what I want to do"?

Comment 6

[Robert Strong (they/them - no direct email)]

As I recall this was implemented for 2.0 but I may be wrong.

This also affects Major Updates since we always notify for Major Updates.

Comment 7

[Dão Gottwald [:dao]]

3.0b2 was the first milestone with this behavior.