Closed Bug 462620 Opened 13 years ago Closed 6 years ago

Use alternating row colors in about:sessionrestore tree view on OS X

Categories

(Toolkit :: Themes, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: faaborg, Unassigned)

References

()

Details

(Keywords: uiwanted)

Attachments

(1 obsolete file)

The tree view should use alternating row colors similar to other tree views on OS X.  I'm not sure why we are doing this on a case by case basis, perhaps we should update the tree view itself since this is the native appearance.
Per bug 459546 comment #22, this is simply due to the fact that we're hiding the column picker - and thus rather a Pinstripe issue.
Component: Session Restore → Theme
QA Contact: session.restore → theme
Hardware: PC → All
Attached patch patch v1 (obsolete) — Splinter Review
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #345849 - Flags: review?(rflint)
How about using 'alternatingbackground="true"' in the xul instead of making all trees default to alternating row colors?
If you're going your route, I don't think you need this?
> tree:not([hidecolumnpicker="true"]) treechildren::-moz-tree-row(odd, selected, focus)
(In reply to comment #3)
> How about using 'alternatingbackground="true"' in the xul instead of making all
> trees default to alternating row colors?

I think we're using trees for lots of things: For example, the places sidebar is a tree (with columnpicker="true"). The patch here doesn't affect that, I think - but I can imagine that lots of people are using trees in the same manner. The toolkit Help viewer uses a tree for the sidebar/left pane, maybe some extensions are using trees in this way etc. My point here is that since we can't know, we should be careful with doing this kind of things.
Let's add alternatingbackground="true", then.
(In reply to comment #6)
> Let's add alternatingbackground="true", then.

Agreed.
Attachment #345849 - Attachment is obsolete: true
Attachment #345849 - Flags: review?(rflint)
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes
Assignee: mstange → nobody
Status: ASSIGNED → NEW
In bug 282127, I made odd tree rows in trees with multiple columns highlighted in Gnomestripe and Pinstripe.

about:sessionrestore should now have line-by-line (odd) highlighting in Pinstripe.
If that's what we want, this bug is fixed.

However, if we want to highlight window by window ("alternate" highlight) instead, like Gnomestripe is now showing, we need to tweak Pinstripe's aboutSessionRestore.css like I did to the Gnomestripe version.
Keywords: uiwanted
This is currently the case as part of the chameleon / in-content styling.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.