462658 - Folder drop down in Bookmarks contextual dialog cannot be closed

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Opening the folder drop down within the bookmarks contextual dialog to choose the destination folder doesn't let you to close it again. It still pops-up again. That's a regression which starts happening between these builds:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/2008080403 Minefield/3.1a2pre ID:2008080403

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/2008080503 Minefield/3.1a2pre ID:2008080503

Checkins in this timeframe: http://tinyurl.com/6mbxly

No idea if bug Bug 433340 could be the cause of the regression. Masayuki?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Just to give an additional note: this doesn't happen on OS X. Looks like Windows only.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'm not sure what is a problem. Would you explain the detail?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Attachment: Opened drop down which cannot be closed

Sure. See the attached screenshot.

Opening the drop down by clicking on it shows up the list of folders. But clicking again on "Unfiled Bookmarks" or the blue arrow lets the drop down open again. Means as often you click you cannot close it that way.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, it's not really my regression. But I'm checking the cause.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

this is a bug of win32 widget. gRollupConsumeEvent is updated in nsIRollupListener::Rollup. We should cache the value in local variable.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Thanks Masayuki. Do you know which patch/bug this could have this bug introduced?

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #6)
> Thanks Masayuki. Do you know which patch/bug this could have this bug
> introduced?

I think that this bug is not a regression. Even if my patch is turning point to reproduce this bug, this bug is there since mozilla beginning, probably.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Ok, but it's strange that it only happens within the bookmarks contextual dialog. All other instances of the whole ui aren't affected.

So we can say that bug 433340 has started the visual appearance in the dialog?

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 345921 [details] [diff] [review]
Patch v1.0

The risk is very low. And this bug is a regression.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 345921 [details] [diff] [review]
Patch v1.0

a191b2=beltzner

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

landed to trunk.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081118 Minefield/3.1b2pre (.NET CLR 3.5.30729) ID:20081118035322

Thanks Masayuki!