462785 - Address Book smart folder builds "Name" field in non-localized way

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Chris Lawson (gone)]

In AddressBookManager.m, line 99

http://mxr.mozilla.org/mozilla/source/camino/src/bookmarks/AddressBookManager.m#99

    name = [NSString stringWithFormat:@"%@ %@", firstName, lastName];


That's most likely wrong for any language that uses a Familyname Givenname format, like a lot of East Asian languages (Japanese and Chinese come to mind) or, as Smokey pointed out, Hungarian. There are other examples, I'm sure.

Philippe and Eiichi, is this indeed wrong as it's implemented in Camino? Do contacts in the Address Book collection show up with "backwards" names?

Comment 1

[philippe (part-time)]

Formally, for Japanese at least, the family name is always listed first - bureaucratic listings, company organigrams, business cards, and written text.
Thus 麻生　太郎 (ASO Taro, the current prime minister).

Amusingly, Apple's Address Book.app, on a newly created Jpn profile, lists the firstName field first (unless that thing picks up the pref from the default admin user). (AB > Preferences > General)
What Safari does is following the order as set in Address book.app (if firstName is first in AB.app, firstName will be listed first in Safari, unless the 'company checkbox' is checked).

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> What Safari does is following the order as set in Address book.app (if
> firstName is first in AB.app, firstName will be listed first in Safari, unless
> the 'company checkbox' is checked).

...unless the card has an order assigned to it via the Card menu, in which case the card's order wins.

/me curses Address Book developers for using "firstName" and "lastName" rather than something useful and direction-agnostic like "familyName" and "personalName" :P

Comment 3

[Chris Lawson (gone)]

I'll fix this when I fix bug 384691, since I'm cleaning up that code anyway.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

FIXED by the checkin for bug 384691.