Closed
Bug 462789
Opened 16 years ago
Closed 16 years ago
Crash [@ inLayoutUtils::GetEventStateManagerFor] with calling getContentState in display: none iframe
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: martijn.martijn, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: crash, testcase, verified1.9.1)
Crash Data
Attachments
(3 files)
|
790 bytes,
text/html
|
Details | |
|
4.59 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
|
5.07 KB,
patch
|
Details | Diff | Splinter Review |
See testcase, which crashes current trunk build after 100ms.
The content of the iframe consists of this:
<html><head></head>
<body>
<script>
setTimeout(doe2, 100);
function doe2() {
netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
var utils = Components.classes["@mozilla.org/inspector/dom-utils;1"]
.getService(Components.interfaces.inIDOMUtils);
utils.getContentState(document.documentElement);
}
</script>
</body>
</html>
|
Reporter | |
Comment 1•16 years ago
|
||
http://crash-stats.mozilla.com/report/index/dd08c1cc-a938-11dd-a826-001cc45a2ce4?p=1
0 xul.dll inLayoutUtils::GetEventStateManagerFor layout/inspector/src/inLayoutUtils.cpp:114
1 xul.dll inDOMUtils::GetContentState layout/inspector/src/inDOMUtils.cpp:238
2 xul.dll NS_InvokeByIndex_P xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
3 xul.dll XPCWrappedNative::CallMethod js/src/xpconnect/src/xpcwrappednative.cpp:2402
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → mats.palmgren
OS: Windows XP → All
Hardware: PC → All
|
|
Assignee | |
Comment 2•16 years ago
|
||
1. add a null check
The mochitest needs Makefile.in from bug 462787 but this patch is otherwise
independent.
Attachment #346095 -
Flags: superreview?(dbaron)
Attachment #346095 -
Flags: review?(dbaron)
Comment on attachment 346095 [details] [diff] [review]
Patch rev. 1
r+sr=dbaron (when adjusted for the comments on bug 462787)
Attachment #346095 -
Flags: superreview?(dbaron)
Attachment #346095 -
Flags: superreview+
Attachment #346095 -
Flags: review?(dbaron)
Attachment #346095 -
Flags: review+
|
|
Reporter | |
Updated•16 years ago
|
Flags: blocking1.9.1?
Flags: blocking1.9.1? → wanted1.9.1+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #346095 -
Flags: approval1.9.1?
|
||
Comment 4•16 years ago
|
||
Comment on attachment 346095 [details] [diff] [review]
Patch rev. 1
a191=beltzner with dbaron's nits addressed
Attachment #346095 -
Flags: approval1.9.1? → approval1.9.1+
Whiteboard: [needs landing]
Mats, can I land this on trunk for you? We should try to land it as soon as possible
|
|
Assignee | |
Comment 6•16 years ago
|
||
|
|
Assignee | |
Comment 7•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/2151c732fb5c
http://hg.mozilla.org/mozilla-central/rev/b57e84df768c
-> FIXED
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla1.9.2a1
Whiteboard: [needs baking and 1.9.1 landing]
|
|
Assignee | |
Comment 8•16 years ago
|
||
Pushed to 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/dae72ad3f21f
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9824567120ea
Keywords: fixed1.9.1
Whiteboard: [needs baking and 1.9.1 landing]
|
|
Reporter | |
Comment 9•16 years ago
|
||
Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20081218 Minefield/3.2a1pre
Status: RESOLVED → VERIFIED
|
||
Comment 10•16 years ago
|
||
verified on Shiretoko: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre ID:20090422042031
Keywords: fixed1.9.1 → verified1.9.1
|
||
Updated•13 years ago
|
Crash Signature: [@ inLayoutUtils::GetEventStateManagerFor]
You need to log in
before you can comment on or make changes to this bug.
Description
•