Closed Bug 462802 Opened 16 years ago Closed 16 years ago

Highly suspect origin code in nsCrossSiteListenerProxy.cpp

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1

People

(Reporter: bzbarsky, Assigned: sicking)

References

Details

(Keywords: fixed1.9.1) 

It looks like this code was added in bug 389508.

The two issues, from my point of view:

1) It doesn't use the innermost URI from the principal.  Should it?
2) It never sends "null" as the Origin; instead it kills off the load if the
   origin is something without a host.  This doesn't seem to be the code's
   intent.

It seems to me that we should factor out the principal -> origin conversion out somewhere and make it correct; there are various abortive attempts at this code in the "origin header on POST" bug as well...

Requesting blocking, since it looks to me like we tried to align ourselves with the access-control spec here and sorta failed.
Flags: blocking1.9.1?
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Assignee: nobody → jonas
Target Milestone: --- → mozilla1.9.1
Bug should fix this, looks like.
Depends on: 464954
Yeah.  I added it to the dep list!  ;)
This was fixed by patch in bug 464954
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Reopening, since that patch got backed out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hopefully bug 464954 should be in for good now.
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.