462849 - Crash [@ nsTableColGroupFrame::DidSetStyleContext] with border-collapse: collapse, removing col and setting border-style

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, which crashes current trunk build after 100ms.

This regressed between 2008-10-31 and 2008-11-01:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2008-10-31+04%3A00%3A00&enddate=2008-11-01+05%3A00%3A00

http://crash-stats.mozilla.com/report/index/67c6093d-a9b3-11dd-b3fe-001a4bd43ed6?p=1
0  	xul.dll  	nsTableColGroupFrame::DidSetStyleContext  	 layout/tables/nsTableColGroupFrame.cpp:219
1 	xul.dll 	nsFrameManager::ReResolveStyleContext 	layout/base/nsFrameManager.cpp:1222
2 	xul.dll 	nsFrameManager::ComputeStyleChangeFor 	layout/base/nsFrameManager.cpp:1501
3 	xul.dll 	nsCSSFrameConstructor::RestyleElement 	layout/base/nsCSSFrameConstructor.cpp:9910
4 	xul.dll 	nsCSSFrameConstructor::ProcessOneRestyle 	layout/base/nsCSSFrameConstructor.cpp:13241
5 	xul.dll 	nsCSSFrameConstructor::ProcessPendingRestyles 	layout/base/nsCSSFrameConstructor.cpp:13335
6 	xul.dll 	PresShell::DoFlushPendingNotifications 	layout/base/nsPresShell.cpp:4541
7 	xul.dll 	PresShell::ReflowEvent::Run 	layout/base/nsPresShell.cpp:6185
8 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:510
9 	xul.dll 	nsBaseAppShell::Run 	widget/src/xpwidgets/nsBaseAppShell.cpp:170
10 	nspr4.dll 	PR_GetEnv 	
11 	firefox.exe 	wmain 	toolkit/xre/nsWindowsWMain.cpp:87
12 	firefox.exe 	firefox.exe@0x2197 	
13 	kernel32.dll 	BaseProcessStart 	

I think a regression from bug 258377.

Comment 1

[Bernd]

Attachment: patch

Comment 2

[Bernd]

fix checked in http://hg.mozilla.org/mozilla-central/rev/0d685a6cfddd

Comment 3

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081104 Minefield/3.1b2pre

Comment 4

[Mats Palmgren (inactive)]

crashtest:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f34356901fa7

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f34356901fa7