462868 - background-color text attribute being exposed as black when it isn't

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Attachment: Testcase

In many pages we are exposing the background color as black, which makes the text appear to be black on black.

My guess is that we get it wrong when no background color was set by the page.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

do not expose text attribute if background-color wasn't specified at all.

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 346392 [details] [diff] [review]
patch

bug 455834 should be fixed as well.

Comment 3

[Marco Zehe (:MarcoZ)]

Comment on attachment 346392 [details] [diff] [review]
patch

Just for clarification: If the background-color value is missing alltogether, IA2 clients should assume "white" or "transparent", correct? Please explicitly document this in our text attributes doc.

Comment 4

[Aaron Leventhal]

Actually, I am confused about that too (comment 3).

Alex, I thought we were going to have default values for various text attributes. When the text attribute is not exposed, use the default value.

But here, this is using a different concept. We're saying it means "not specified". But there is a background color that will be used from the user's Firefox or system preferences.

Comment 5

[alexander :surkov (:asurkov)]

Actually I'm confused as well. Iirc we should expose rgb(r, g, b) but there is no background at all. It's possibly white. But it's not from point of view gecko layout implementation. It's possibly transparent. But it's not because it should mean we should see desktop. Therefore I thought it's possibly good to follow the gecko layout concept: if there is no background then it's nothing to expose, even for default attributes.

Comment 6

[Aaron Leventhal]

We need to get feedback from the AT developers. Check it in as it is and we'll see what people say. 

They will not like it if they will want know what the actual background color is currently (and don't care whether it's because its the default color or was set).

Do we do the same for foreground color? What do we do if it was not specified?

Comment 7

[alexander :surkov (:asurkov)]

(In reply to comment #6)

> Do we do the same for foreground color? What do we do if it was not specified?

No, color is always specified.

Comment 8

[Marco Zehe (:MarcoZ)]

What about if there's no background color specified, get the background color that's set in the operating system's current Display settings? Do we have access to that? I agree with Aaron, we should not expose nothing.

Comment 9

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 10

[alexander :surkov (:asurkov)]

bug 455834 must be duplicate of this bug.

Comment 11

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/mozilla-central/rev/e4cc992e5dd4

Comment 12

[Marco Zehe (:MarcoZ)]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2a1pre) Gecko/20081211 Minefield/3.2a1pre

Comment 13

[alexander :surkov (:asurkov)]

there is nothing to document (remove 'dev-doc-needed' keyword)

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 350564 [details] [diff] [review]
patch2

a191=beltzner

Comment 15

[Marco Zehe (:MarcoZ)]

Pushed on Alexander's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/25612a6d277c

Comment 16

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090120 Shiretoko/3.1b3pre