462939 - Slow test js1_6/extensions/regress-456826.js

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

This test is very slow; it takes 45+ minutes by itself on my MacBook. Should it be added to slow-n?

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: slow-n-1.8.1.tests

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: slow-n-1.9.0.tests

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: slow-n-1.9.1.tests

Comment 4

[Bob Clary [:bc] (inactive)]

David, try out the slow-n-1.9.1.tests for 1.9.1 mozilla-central/tracemonkey work. 

These show-n-*.tests include tests which require longer than 8 minutes for at least one combination of test type, build type etc. 

I would like to remove slow-n.tests and add slow-n-1.8.1.tests, slow-n-1.9.0.tests and slow-n-1.9.1.tests so that we can track "slowness" differently on each branch. Objections?

Comment 5

[Bob Clary [:bc] (inactive)]

Attachment: patch

Comment 6

[David Mandelin [:dmandelin]]

Whoops, don't know how I missed your previous comment. Anyway, sounds like a good idea. 

I tried the new patch with slow-n-1.9.1.tests with current TraceMonkey. (Are they intended to be used together?) I had to add 2 more slow tests:

ecma_3/RegExp/regress-307456.js
ecma_3/RegExp/regress-330684.js

They seemed to be in the original slow-n but not in your new 1.9.1. I'm not sure if they were supposed to have been made not-slow or something. Please check into this and tell me if I'm doing something wrong or if they do need to be added to the list.

Comment 7

[Bob Clary [:bc] (inactive)]

Attachment: patch v2

Sorry, the previous patch missed tests that were slow on all branches. These should be better. They are intended to be branch specific. So, if you are testing mozilla-central or tracemonkey use slow-n-1.9.1.tests, etc. slow-n.tests is kind of old and hasn't had any review on if the old tests have become non-slow.

Comment 8

[David Mandelin [:dmandelin]]

Comment on attachment 349467 [details] [diff] [review]
patch v2

This works for me. I just did a full run in 4m06s using slow-n-1.9.1.tests. I did get this line of output:

-#- testcase 'js1_7/extensions/regress-458679.js' not found.

I have seen such things before. I don't know exactly what conditions cause them but they don't seem harmful. (And it could be some sort of TM vs. M-C mismatch in this case.)

Comment 9

[Bob Clary [:bc] (inactive)]

Checking in slow-n.tests;
/cvsroot/mozilla/js/tests/slow-n.tests,v  <--  slow-n.tests
new revision: 1.11; previous revision: 1.10
done
RCS file: /cvsroot/mozilla/js/tests/slow-n-1.8.1.tests,v
done
Checking in slow-n-1.8.1.tests;
/cvsroot/mozilla/js/tests/slow-n-1.8.1.tests,v  <--  slow-n-1.8.1.tests
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/slow-n-1.9.0.tests,v
done
Checking in slow-n-1.9.0.tests;
/cvsroot/mozilla/js/tests/slow-n-1.9.0.tests,v  <--  slow-n-1.9.0.tests
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/js/tests/slow-n-1.9.1.tests,v
done
Checking in slow-n-1.9.1.tests;
/cvsroot/mozilla/js/tests/slow-n-1.9.1.tests,v  <--  slow-n-1.9.1.tests
initial revision: 1.1
done

Comment 10

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/f39dfeda6a45