462953 - Remove unimplemented media attributes/methods from media IDL

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Features which are not implemented should not have placeholders in their IDL, they should be removed from the IDL, and new bugs filed to implement them.

These features are:
* nsIDOMHTMLMediaElement::GetBufferingRate()
* nsIDOMHTMLMediaElement::GetBufferingThrottled()
* nsIDOMHTMLMediaElement::GetBuffered()
* nsIDOMHTMLMediaElement::GetBufferedBytes()
* nsIDOMHTMLMediaElement::GetPlayed()
* nsIDOMHTMLMediaElement::GetSeekable()
* nsIDOMHTMLMediaElement::AddCueRange()
* nsIDOMHTMLMediaElement::RemoveCueRanges()

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

* nsIDOMHTMLVideoElement::poster

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch v1

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch v2 - leave in harmless IDLs

As Patch v1 but doesn't remove nsIDOMHTMLVoidCallback, nsIDOMHTMLTimeRanges, nsIDOMHTMLByteRanges at Roc's request.

Comment 4

[cajbir (:cajbir)]

I think you missed these:

attribute float start;
attribute float end;
attribute float loopStart;
attribute float loopEnd;
attribute unsigned long playCount;
attribute unsigned long currentLoop;

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch v3

Also remove stuff pointed out by Chris Double. Removes PlaybackRate support too. Ogg and (the pending) audio backends don't support it, so I'm removing it too. 

Once audio's landed, this patch will need to be updated to remove the audioDecoder's PlaybackRateChanged() method, as it's inherited from nsMediaDecoder::PlaybackRateChanged(), which is pure virtual, but is removed in this patch.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 346339 [details] [diff] [review]
Patch v3

But wait, there's more!

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch v4 [Checkin: Comment 9]

Doesn't remove nsMediaDecoder::PlaybackRateChanged(), adds comments where spec-required stuff is removed. Removes <source>'s pixelRatio and media.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 346355 [details] [diff] [review]
Patch v4
[Checkin: Comment 9]

We should get this in the beta2 landing queue.

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

http://hg.mozilla.org/mozilla-central/rev/250cef7cf0d6