Closed Bug 462964 Opened 16 years ago Closed 16 years ago

nsIDownloadManager should have removeDownloadsByTimeframe

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b2

People

(Reporter: johnath, Assigned: sdwilsh)

References

Details

Attachments

(1 file, 1 obsolete file)

v1.0
10.55 KB, patch
Details | Diff | Splinter Review 
There's already "activeDownloads", an nsISimpleEnumerator of downloads in progress, but there isn't an enumerator of all downloads.   This would make it much easier to iterate over downloads to find deletables.  Indeed, it would be particularly nice if download manager had something like Places' removePagesByTimeframe, but in the absence of that, at *least* having an iterator of downloads seems generically useful.
Morphing bug based on discussions with sdwilsh and gavin.  What I *actually* want is the download manager equivalent of nsIBrowserHistory's removePagesByTimeframe.

Should take a start time and end time (inclusive) in microseconds (hi, PRTime!) since epoch.
Summary: nsIDownloadManager should have a way to get a list of all downloads → nsIDownloadManager should have removeDownloadsByTimeframe
Attached patch v1.0 (obsolete) — — Splinter Review 
Assignee: nobody → sdwilsh
Status: NEW → ASSIGNED

        Attachment #346323 -
        Flags: review?(mconnor)

    
    

    
  
Comment on attachment 346323 [details] [diff] [review]
v1.0

r=me

        Attachment #346323 -
        Flags: review?(mconnor) → review+

    
  
Whiteboard: [has patch][has review][can land]
Target Milestone: --- → mozilla1.9.1b2

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1.0
        — 
          — Splinter Review
      

    


  
This is for checkin in case I don't get to it.  All you have to do is hg import this and it has the commit message ready and everything.

        Attachment #346323 -
        Attachment is obsolete: true

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/eef8801a25bd
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: