462997 - [Port Bug 454949] On reload Current Build ID disappears from the title bar (Nightly Tester Tools thing)

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Philip Chee]

Attachment: Remove the contenttitlesetting attribute from the window [Bug 454949]

+++ This bug was initially created as a clone of Bug #454949 +++

To reproduce:
- Install Nightly Tester Tools: https://addons.mozilla.org/en-US/firefox/addon/6543
- Visit a web page, notice the title in the title bar with the Current Build ID displayed (something that NTT magically adds)
- Reload the web page

Actual result:
The Current Build ID has disappeared from the title bar. It should have stayed.

Not sure how NTT does add the Build ID to the title bar, but since this regressed when bug 118704 got fixed, I suspect this might be a valid bug. Dave might know how NTT adds the Build ID to the title bar.

Comment 1

[[e-mail]]

Dup of 457548?

Comment 2

[Philip Chee]

> Dup of 457548?
Dependent I think

Comment 3

[Stefan [:stefanh]]

(In reply to comment #2)
> > Dup of 457548?
> Dependent I think

Yeah, I guess I could fix it there. Should probably check how NTT adds the buildID and compare with debugQA.

Comment 4

[Stefan [:stefanh]]

Note that the removal of contenttitlesetting="true" broke mac on Firefox...

Comment 5

[Stefan [:stefanh]]

(In reply to comment #4)
> Note that the removal of contenttitlesetting="true" broke mac on Firefox...

See bug 463253.

Comment 6

[[e-mail]]

Comment on attachment 346216 [details] [diff] [review]
Remove the contenttitlesetting attribute from the window [Bug 454949]

Minusing as per stefanh's observations

Comment 7

[Stefan [:stefanh]]

Comment on attachment 346216 [details] [diff] [review]
Remove the contenttitlesetting attribute from the window [Bug 454949]

I think we can do this for b1. On mac, what we display in the title bar won't be correct, but it's at least the old behaviour. See bug 457548 (first comment and my 2 last) why I think we can do this for now.

Comment 8

[Stefan [:stefanh]]

Comment on attachment 346216 [details] [diff] [review]
Remove the contenttitlesetting attribute from the window [Bug 454949]

This will fix bug 457548 in a sense that it will give us the old window title behavior on mac which is better than the current, broken one.

Comment 9

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/53f9c5558d5a