463022 - browser_privatebrowsing_ui.js fails on mac

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Dave Townsend [:mossop] (PTO until July 20)]

I don't think there are keyboard shortcuts for opening menus on mac so this test which for some reason does this fails there. I have disabled the test on mac to avoid blocking everyone elses work for any longer than it already has. It should be fixed a.s.a.p.

Comment 1

[(no longer active)]

So, Mac doesn't have access keys at all?

I need to investigate other ways of opening menus and selecting menu items.  Any help is appreciated!

Comment 2

[(no longer active)]

Attachment: Patch (v1)

So I think the best approach here is to ditch the menu item testing altogether, and resort to just making sure that the XUL command associated with the menu item using the |command| attribute is working properly.  This should work on Mac and other platforms alike.

Comment 3

[(no longer active)]

This patch also has the advantage of removing another timeout from the private browsing tests.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 348181 [details] [diff] [review]
Patch (v1)

r=mconnor, sorry for the delay.

Comment 5

[(no longer active)]

Pushed to mozilla-central: <http://hg.mozilla.org/mozilla-central/rev/4671612cb6d5>

Comment 6

[(no longer active)]

Attachment: mq patch for check-in on 1.9.1

Comment 7

[(no longer active)]

Landed on 1.9.1 <http://hg.mozilla.org/releases/mozilla-1.9.1/rev/90badede8b19>

Comment 8

[(no longer active)]

Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

All tests pass with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20081229 Shiretoko/3.1b3pre