Closed Bug 463023 Opened 13 years ago Closed 13 years ago

nsIAutoCompleteController::searchStatus is initialized to 0, which is not a documented constant (nsAutoCompleteController::mSearchStatus)

Categories

(Toolkit :: Autocomplete, defect)

defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla1.9.2a1

People

(Reporter: asqueella, Assigned: rsesek)

Details

(Keywords: verified1.9.1)

Attachments

(2 files)

Whiteboard: [good first bug]
Attachment #355180 - Flags: review?
Attachment #355180 - Flags: review? → review?(gavin.sharp)
Attachment #355180 - Flags: review?(gavin.sharp) → review+
Comment on attachment 355180 [details] [diff] [review]
Patch
[Checkin: Comment 7]

Was this proving to be a problem in practice? I'd be interested to know the details if it was. Thanks for the patch!
A test for this would be nice too, if you're interested in doing that. There are some examples here:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/tests/unit/
Assignee: nobody → rsesek
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [good first bug]
Here's a unit test to go along with the patch.
Attachment #355191 - Flags: review?(gavin.sharp)
I don't think this was causing any actual problems, unless somebody was checking  searchStatus before doing anything. Once the search has been started, the status would have been set correctly.
Comment on attachment 355191 [details] [diff] [review]
Unit test
[Checkin: Comment 8]

I guess we could have just added this to one of the existing tests given how simple it is, but this will do! Thanks again.
Attachment #355191 - Flags: review?(gavin.sharp) → review+
Comment on attachment 355180 [details] [diff] [review]
Patch
[Checkin: Comment 7]

http://hg.mozilla.org/mozilla-central/rev/05f55cd484b8
Attachment #355180 - Attachment description: Patch → Patch [Checkin: Comment 7]
Comment on attachment 355191 [details] [diff] [review]
Unit test
[Checkin: Comment 8]

http://hg.mozilla.org/mozilla-central/rev/4dd8076af484
Attachment #355191 - Attachment description: Unit test → Unit test [Checkin: Comment 8]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 355191 [details] [diff] [review]
Unit test
[Checkin: Comment 8]

askin approval for 1.9.1, code cleanup, no risk.
Attachment #355191 - Flags: approval1.9.1?
Attachment #355191 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 355180 [details] [diff] [review]
Patch
[Checkin: Comment 7]

a191=beltzner
Attachment #355180 - Flags: approval1.9.1+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.