463023 - nsIAutoCompleteController::searchStatus is initialized to 0, which is not a documented constant (nsAutoCompleteController::mSearchStatus)

Status: VERIFIED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Nickolay_Ponomarev]

initialization code: 
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/src/nsAutoCompleteController.cpp#75

Contradicting interface documentation:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/public/nsIAutoCompleteController.idl#47

probably should be initialized to STATUS_NONE (==1).

Comment 1

[Robert Sesek]

Attachment: Patch [Checkin: Comment 7]

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 355180 [details] [diff] [review]
Patch
[Checkin: Comment 7]

Was this proving to be a problem in practice? I'd be interested to know the details if it was. Thanks for the patch!

Comment 3

[:Gavin Sharp [email: [e-mail]]]

A test for this would be nice too, if you're interested in doing that. There are some examples here:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/tests/unit/

Comment 4

[Robert Sesek]

Attachment: Unit test [Checkin: Comment 8]

Here's a unit test to go along with the patch.

Comment 5

[Robert Sesek]

I don't think this was causing any actual problems, unless somebody was checking  searchStatus before doing anything. Once the search has been started, the status would have been set correctly.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 355191 [details] [diff] [review]
Unit test
[Checkin: Comment 8]

I guess we could have just added this to one of the existing tests given how simple it is, but this will do! Thanks again.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 355180 [details] [diff] [review]
Patch
[Checkin: Comment 7]

http://hg.mozilla.org/mozilla-central/rev/05f55cd484b8

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 355191 [details] [diff] [review]
Unit test
[Checkin: Comment 8]

http://hg.mozilla.org/mozilla-central/rev/4dd8076af484

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 355191 [details] [diff] [review]
Unit test
[Checkin: Comment 8]

askin approval for 1.9.1, code cleanup, no risk.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 355191 [details] [diff] [review]
Unit test
[Checkin: Comment 8]

a191=beltzner

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 355180 [details] [diff] [review]
Patch
[Checkin: Comment 7]

a191=beltzner

Comment 12

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fc0dff7dd975
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/39ca07d6c5b3