Remove remaining traces of Mozilla 1.8 compatibility

VERIFIED FIXED in 1.0b1

Status

defect
--
trivial
VERIFIED FIXED
11 years ago
8 years ago

People

(Reporter: martinschroeder, Assigned: martinschroeder)

Tracking

Trunk
1.0b1
Dependency tree / graph

Details

Attachments

(2 attachments, 1 obsolete attachment)

There are still some places that contain code written to be compatible with Mozilla 1.8 or earlier (see bug 455869 comment 14). We can safely remove this code now. The pieces for clipboard.js follow in a general 'calendar clipboard cleanup' bug.
Attachment #346267 - Flags: review?(philipp)
Comment on attachment 346267 [details] [diff] [review]
[checked in w/o password manager part] Patch v1

Are you sure we can do the password manager stuff yet? Last I checked, Thunderbird still uses wallet due to mailnews dependancies. This may have changed though

r=philipp with that checked
Attachment #346267 - Flags: review?(philipp) → review+
Pushed patch without password manager part to comm-central <http://hg.mozilla.org/comm-central/rev/83675cb6e479>
Target Milestone: --- → 1.0
Depends on: 239131
Attachment #346267 - Attachment description: Patch v1 → [checked in w/o password manager part] Patch v1
Carrying over r+.
Attachment #353833 - Flags: review+
Attachment #353833 - Attachment is patch: true
Attachment #353833 - Attachment mime type: application/octet-stream → text/plain
Updated patch for moved code. Carrying over r+.
Attachment #353833 - Attachment is obsolete: true
Attachment #356702 - Flags: review+
Password manager part pushed to comm-central <http://hg.mozilla.org/comm-central/rev/f3b7d770500b>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
If I understand correctly: nsIPasswordManager is the old one from 'wallet', nsILoginManager is the new one added recently to Thunderbird. Due to the change from this patch Lightning will not work in older Thunderbird builds. 

Therefore the minVersion of the extensions should be raised to 3.0b2pre or the support for nsIPasswordManager should be added back temporary until a new Thunderbird release build is available.

Comment 7

11 years ago
Checked in lightning build 20090128 -> VERIFIED.
Status: RESOLVED → VERIFIED
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.