463058 - Remove remaining traces of Mozilla 1.8 compatibility

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Martin Schröder [:mschroeder]]

Attachment: [checked in w/o password manager part] Patch v1

There are still some places that contain code written to be compatible with Mozilla 1.8 or earlier (see bug 455869 comment 14). We can safely remove this code now. The pieces for clipboard.js follow in a general 'calendar clipboard cleanup' bug.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 346267 [details] [diff] [review]
[checked in w/o password manager part] Patch v1

Are you sure we can do the password manager stuff yet? Last I checked, Thunderbird still uses wallet due to mailnews dependancies. This may have changed though

r=philipp with that checked

Comment 2

[Martin Schröder [:mschroeder]]

Pushed patch without password manager part to comm-central <http://hg.mozilla.org/comm-central/rev/83675cb6e479>

Comment 3

[Martin Schröder [:mschroeder]]

Attachment: Patch v1 (password manager part)

Carrying over r+.

Comment 4

[Martin Schröder [:mschroeder]]

Attachment: Patch v2 (password manager part, now calAuthUtils.jsm)

Updated patch for moved code. Carrying over r+.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Password manager part pushed to comm-central <http://hg.mozilla.org/comm-central/rev/f3b7d770500b>

-> FIXED

Comment 6

[Stefan Sitter [:ssitter]]

If I understand correctly: nsIPasswordManager is the old one from 'wallet', nsILoginManager is the new one added recently to Thunderbird. Due to the change from this patch Lightning will not work in older Thunderbird builds. 

Therefore the minVersion of the extensions should be raised to 3.0b2pre or the support for nsIPasswordManager should be added back temporary until a new Thunderbird release build is available.

Comment 7

[Andreas Treumann]

Checked in lightning build 20090128 -> VERIFIED.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".