463116 - Re-implement runtest.pl for leak and bloat tests in python.

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

There's a couple of reasons I want to do this, the main one being that I think I want to use some of the process functionality from automation.py to start and stop fake server processes which will make extending the tests easier.

Attaching patch which I think emulates the current runtest.pl.

Comment 1

[Philippe M. Chiasson (:gozer)]

Comment on attachment 346337 [details] [diff] [review]
The fix

Small problem that you have correctly ported over from the original script. When actually running commands, it would be important to capture the status code, and if not successfull, bail out and return it out as a status code, so buildbot knows something failed, instead of just logging it to stderr

Comment 2

[Philippe M. Chiasson (:gozer)]

Attachment: [checked in] The Fix v2

Slight fixup including aborting on command failure and passing that status code back to buildbot, so it knows something failed.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 346478 [details] [diff] [review]
[checked in] The Fix v2

Yep, I'm happy with the additional changes.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 346478 [details] [diff] [review]
[checked in] The Fix v2

This has now been pushed: http://hg.mozilla.org/comm-central/rev/8503d3f60e36

Comment 5

[Philippe M. Chiasson (:gozer)]

Updated buildbot configuration to invoke the python version, kill the perl one at will.

http://hg.mozilla.org/build/buildbot-configs/rev/39fbffc754d8

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #5)
> Updated buildbot configuration to invoke the python version, kill the perl one
> at will.

I've got some future changes planned for that directory, so I will remove the file at the same time as those.

Comment 7

[Mark Banner (:standard8)]

Attachment: The fix

Remove runtest.pl. SeaMonkey doesn't use it anymore, Thunderbird doesn't, and runtest.py is the thing to use now anyway.

Comment 8

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/0d309f72fcf3

This bug is fixed now.