463162 - Pick-a-media-resource accepts source from non-source elements

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Media's pick-a-media-resource (see URL for spec) is supposed to accept resources from <source> elements which are children of <video>, when <video> doesn't have a src attribute. But currently we accept src attributes from any child element of the media element, e.g.:

<video controls>
  <dogfood src="video.ogg" type="video/ogg">
</video>

The above will still load "video.ogg", but it shouldn't according to the spec, the dogfood element needs to be a source element.

We can fix this in nsHTMLMediaElement::PickMediaElement() by QI'ing the children of <media> to nsIDOMHTMLSourceElement, and only taking the src attribute if the QI'd ref is non-null.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Testcase: http://pearce.org.nz/mozilla/bug_463162.html

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: patch v0

Check that the child is a source tag before using it.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think you need to check whether the source element is in the HTML namespace too.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

And add that to the test too!

Comment 5

[Matthew Gregan [:kinetik]]

Attachment: patch v1

Check namespace, extend test to cover this case.

Comment 7

[Matthew Gregan [:kinetik]]

The fix and test for this are included in the patch attached to bug 464158, so this bug should depend on that one.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fixed by checkin for bug 464158.