463191 - Sunstudion assertion happenn when compiling core/AbcEnv.cpp.

Status: VERIFIED WORKSFORME

(Tamarin Graveyard :: Build Config, defect)

Description

[Leon Sha]

Attachment: temporary patch

CC -o core/AbcEnv.o -DAVMPLUS_CDECL -DAVMPLUS_SPARC -DMMGC_INTERIOR_PTRS -DUNIX -DSOLARIS -DSOFT_ASSERTS -DAVMPLUS_UNIX    -xO5    -I/export/home/leon.sha/uild/tamarin-redux -I/export/home/leon.sha/uild/tamarin-redux/MMgc -I/export/home/leon.sha/uild/tamarin-redux/core -I/export/home/leon.sha/uild/tamarin-redux/codegen -I/export/home/leon.sha/uild/tamarin-redux/pcre  -c core/AbcEnv.i
"/export/home/leon.sha/uild/tamarin-redux/core/BitSet.h", line 97: Warning: bits hides avmplus::BitSet::bits.
"/export/home/leon.sha/uild/tamarin-redux/core/BitSet.h", line 136: Warning: bits hides avmplus::BitSet::bits.
"/export/home/leon.sha/uild/tamarin-redux/core/BitSet.h", line 157: Warning: bits hides avmplus::BitSet::bits.
 >> Assertion:   (../lnk/tmplmatchargs.cc, line 193)
    while processing core/AbcEnv.i at line 8006.
make: *** [core/AbcEnv.o] Error 1

This is a bug in sun compiler when it parse template. I have attached a temporary in case someone want to build tamarin-redux on solaris. We will wait compiler to be fixed and will not try to push this patch in.

Comment 1

[Steven Johnson]

Yeah, I'd prefer not to push this in if a fix for the Sun compiler is forthcoming... AFAIK all other compilers of interest can correctly handle this at present. (Good to have the patch handy for folks who need it, though.)

Comment 2

[Trevor Baker]

Is a fix for the Sun compiler forthcoming?  Is there an eta?

Comment 3

[Leon Sha]

Attachment: updated patch

Comment 4

[Brent Baker]

Updated patch (347705) does fix the compilation issues on Solaris with the redux tip 1090.

Comment 5

[Brent Baker]

Previous comment (#4) was before I checked the debugger builds...

There is an assertion from the compiler happening in the debugger builds
(release_debugger and debug_debugger):

../configure.py --enable-shell --enable-debugger
../configure.py --enable-shell --enable-debug --enable-debugger

>> Assertion:   (../lnk/tmplmatchargs.cc, line 193)
    while processing MMgc/GC.i at line 8407.
make: *** [MMgc/GC.o] Error 1


http://tamarin-builds.mozilla.org/sandbox/builders/solaris-sparc/builds/3/steps/Build_Release_Debugger/logs/stdio

Comment 6

[Leon Sha]

Attachment: patch v 3

Updated patch. I hate this sunstudio bug.

Comment 7

[Leon Sha]

Attachment: patch v4

Comment 8

[Steven Johnson]

It might make sense to roll this patch in to Tamarin until a compiler fix (or alternate compiler) is found for Solaris ... there's no downside to it in terms of code size or complexity.

Comment 9

[Leon Sha]

Attachment: patch v5

Comment 10

[Dan Schaffer]

adding triage+.  We heard in late Jan 2009 fix may be rolled into sun studio compiler.  if so waiting for compiler fix is preferable.

Comment 11

[Leon Sha]

Sun patch 124863-09 fixed this bug. Mark as resolved.