Closed
Bug 463212
Opened 16 years ago
Closed 16 years ago
menupopups shouldn't inherit text-shadow
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b2
People
(Reporter: nightstalkerz, Assigned: dao)
References
Details
(Keywords: verified1.9.1)
Attachments
(1 file)
|
494 bytes,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081105 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081105 Minefield/3.1b2pre
When right clicking on the search box in the all tabs preview, the context menu is blurred.
Reproducible: Always
Steps to Reproduce:
1. Open at least 2 tabs
2. Click the all tabs button
3. Right click on the textbox
Actual Results:
The context menu appears but the text is very blurred.
Expected Results:
The contexxt menu appears normally.
|
||
Comment 1•16 years ago
|
||
Looks indeed strange.
Blocks: 436304
Status: UNCONFIRMED → NEW
Component: General → Tabbed Browser
Ever confirmed: true
Keywords: regression
QA Contact: general → tabbed.browser
Version: unspecified → Trunk
|
Assignee | |
Updated•16 years ago
|
Component: Tabbed Browser → General
Keywords: regression
Product: Firefox → Core
QA Contact: tabbed.browser → general
|
|
Assignee | |
Comment 2•16 years ago
|
||
Seems like text-shadow shouldn't be inherited to menupopups. I'm not sure about where to fix this... xul.css, toolkit themes, somewhere else?
Blocks: 438517
|
||
Comment 3•16 years ago
|
||
I don't claim to know the internal details of this UI but most popups are top-level children and so don't have to worry about inheriting unusual styles.
|
|
Assignee | |
Comment 4•16 years ago
|
||
This bug refers to the usual context menu of the textbox, which is an anonymous <menupopup> element within the textbox.
|
Reporter | |
Comment 6•16 years ago
|
||
This doesn't seem to happen on Vista.
|
||
Updated•16 years ago
|
OS: All → Windows XP
Hardware: All → PC
|
||
Comment 7•16 years ago
|
||
Markus, as I said in comment 5 it also happens on OS X.
OS: Windows XP → All
Hardware: PC → All
|
|
||
Comment 8•16 years ago
|
||
Huh, I didn't mean to change that, sorry.
|
|
Assignee | |
Comment 9•16 years ago
|
||
(In reply to comment #6)
> This doesn't seem to happen on Vista.
It's probably less visible because the text-shadow is white.
|
|
Assignee | |
Updated•16 years ago
|
Component: General → XUL Widgets
Product: Core → Toolkit
QA Contact: general → xul.widgets
Summary: Context menu on all tabs preview is blurred → menupopups shouldn't inherit text-shadow
|
|
Assignee | |
Comment 10•16 years ago
|
||
|
|
Assignee | |
Updated•16 years ago
|
Flags: blocking1.9.1?
|
||
Comment 11•16 years ago
|
||
Blocking, but it can go out like this in b2 as long as we fix for final.
Flags: blocking1.9.1? → blocking1.9.1+
Target Milestone: --- → mozilla1.9.1
|
||
Updated•16 years ago
|
Attachment #346625 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 12•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.9.1 → mozilla1.9.1b2
|
|
||
Comment 13•16 years ago
|
||
Verified with:
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081107 Minefield/3.1b2pre ID:20081107224438
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081107 Minefield/3.1b2pre ID:20081107224639
Status: RESOLVED → VERIFIED
|
|
||
Updated•16 years ago
|
Keywords: fixed1.9.1
|
|
||
Updated•16 years ago
|
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•