463339 - JS engine build system doesn't update existing libmozjs.so in depend builds.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Johnny Stenback (:jst)]

Doing a depend build of Firefox copies libmozjs.so into dist/bin in the obj dir, making a change in the JS engine source and rebuilding doesn't update the libmozjs.so file in the obj directory.

There's a dist/bin directory in js/src as well as in the top of the firefox object directory, so I don't know if that's part of the confusion or not. Also, seems like we'd want there to be a symbolic link in the dist/bin directory, rather than a copy of the file.

This is biting developers, so we should attempt to fix this ASAP.

Comment 1

[Jim Blandy :jimb]

Does it work to 'cd $objdir/config/js; make' after doing the build in $objdir/js/src?

Comment 2

[Jim Blandy :jimb]

(Not as a proper fix, of course; just to work around.)

Comment 3

[Johnny Stenback (:jst)]

Sadly, no. Deleting libmozjs.so out of the proper dist/bin directory and re-making in js/src and js/src/config does not put the file back into the dist/bin directory.

Comment 4

[Johnny Stenback (:jst)]

Duh, yes, making in config/js (as opposed to js/src/config) does indeed copy the file into the right place.

Comment 5

[Jim Blandy :jimb]

Attachment: Bug 463339: Have js/src use symlinks when installing in dist.

A directory's 'libs' target should create symlinks in the top-level
dist/bin and dist/lib directories to the libraries (and any other
generated files) in the build tree, so that when one has changed
sources in $src/js/src, simply running 'make' in $obj/js/src and then
re-running $obj/dist/bin/firefox will pick up the new libraries.

The js/src/Makefile.in 'install' target has many double-colon rules
with commands; we'd like to use these all in two circumstances:

. For 'make install' in a stand-alone js/src build.  Since we're
  following GNU behavior, this should copy the files it's installing.

. For 'make libs' in an in-tree js/src build.  To interact properly
  with the rest of the Mozilla build system, this should create
  symlinks as explained above.

To accomplish this, we use plain old $(INSTALL) in all the install
targets, have js/src/Makefile.in set NSDISTMODE to copy (to get the
GNU behavior), and then have config/js/Makefile.in override that (to
get the Mozilla in-tree behavior).

Comment 6

[Jim Blandy :jimb]

Ben, you were concerned with my use of NSDISTMODE in the original 97954 patch; I think the attached patch is suggesting going back to something that resembles this behavior, so I wanted you to review it.  I've put my rationale in the comments, with more details in the log message; what do you think?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed baff98e6d9ec

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Backed out. This appears to have broken the Mac build: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1227058740.1227058895.23152.gz

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348103 [details] [diff] [review]
Bug 463339: Have js/src use symlinks when installing in dist.

We're closing up for beta2 and this hasn't landed yet, so we'll hold off until after we branch.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

(unless this blocks, at which point someone should mark it as such)

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348103 [details] [diff] [review]
Bug 463339: Have js/src use symlinks when installing in dist.

a191=beltzner

Comment 12

[Jim Blandy :jimb]

I'm testing a revised patch for this now.

Comment 13

[Jim Blandy :jimb]

Attachment: Bug 463339: Have js/src use symlinks when installing in dist.

[minor revision; see handling of NSDISTMODE.]

A directory's 'libs' target should create symlinks in the top-level
dist/bin and dist/lib directories to the libraries (and any other
generated files) in the build tree, so that when one has changed
sources in $src/js/src, simply running 'make' in $obj/js/src and then
re-running $obj/dist/bin/firefox will pick up the new libraries.

The js/src/Makefile.in 'install' target has many double-colon rules
with commands; we'd like to use these all in two circumstances:

. For 'make install' in a stand-alone js/src build.  Since we're
  following GNU behavior, this should copy the files it's installing.

. For 'make libs' in an in-tree js/src build.  To interact properly
  with the rest of the Mozilla build system, this should create
  symlinks as explained above.

To accomplish this, we use plain old $(INSTALL) in all the install
targets, have js/src/Makefile.in set NSDISTMODE to copy (to get the
GNU behavior), and then have config/js/Makefile.in override that (to
get the Mozilla in-tree behavior).

Comment 14

[Jim Blandy :jimb]

Landed in Mozilla Central, changeset 1fa974797b0c.

Comment 15

[Jim Blandy :jimb]

I don't think this bug needs to be landed in 1.9.1, as the problem ended up being fixed in a different way by bug 471188:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/27a7287e4809