Ranges should participate in cycle collection

RESOLVED FIXED in mozilla1.9.1b3

Status

()

defect
P2
normal
RESOLVED FIXED
11 years ago
6 years ago

People

(Reporter: peterv, Assigned: smaug)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.1b3
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Reporter

Description

11 years ago
Posted patch v1Splinter Review
Spinning off from bug 335998, this is simply a general leak fix that we should do.
Attachment #346655 - Flags: superreview?(peterv)
Attachment #346655 - Flags: review?(peterv)
Reporter

Comment 1

11 years ago
Comment on attachment 346655 [details] [diff] [review]
v1

>diff --git a/content/base/src/nsRange.cpp b/content/base/src/nsRange.cpp

>+NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(nsRange)
>+  NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mStartParent)
>+  NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mEndParent)

This needs to call DoSetRange, I think.
Attachment #346655 - Flags: superreview?(peterv)
Attachment #346655 - Flags: superreview+
Attachment #346655 - Flags: review?(peterv)
Attachment #346655 - Flags: review+
Assignee

Comment 2

11 years ago
Ah, true.
Assignee

Comment 3

11 years ago
Posted patch v2Splinter Review
Calls reset, which calls DoSetRange with null/0 parameters.
Assignee

Updated

11 years ago
Attachment #346658 - Flags: approval1.9.1?
Assignee

Updated

11 years ago
Blocks: 448993
Assignee

Comment 4

11 years ago
Note, this is needed for 1.9.1 for fix crasher bug 448993.
Assignee

Comment 5

11 years ago
er, 'to fix', or something
Comment on attachment 346658 [details] [diff] [review]
v2

a191=beltzner
Attachment #346658 - Flags: approval1.9.1? → approval1.9.1+
Should this not block, as well?
Flags: blocking1.9.1?
Sure.
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Assignee

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [needs-1.9.1-landing]
Assignee

Comment 9

11 years ago
Fixed on trunk and 1.9.1
Whiteboard: [needs-1.9.1-landing]
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.1b3
Component: DOM: Traversal-Range → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.