Closed
Bug 463410
Opened 17 years ago
Closed 17 years ago
Ranges should participate in cycle collection
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: peterv, Assigned: smaug)
References
Details
(Keywords: fixed1.9.1)
Attachments
(2 files)
2.22 KB,
patch
|
peterv
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
2.12 KB,
patch
|
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Spinning off from bug 335998, this is simply a general leak fix that we should do.
Attachment #346655 -
Flags: superreview?(peterv)
Attachment #346655 -
Flags: review?(peterv)
Reporter | ||
Comment 1•17 years ago
|
||
Comment on attachment 346655 [details] [diff] [review]
v1
>diff --git a/content/base/src/nsRange.cpp b/content/base/src/nsRange.cpp
>+NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(nsRange)
>+ NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mStartParent)
>+ NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mEndParent)
This needs to call DoSetRange, I think.
Attachment #346655 -
Flags: superreview?(peterv)
Attachment #346655 -
Flags: superreview+
Attachment #346655 -
Flags: review?(peterv)
Attachment #346655 -
Flags: review+
Assignee | ||
Comment 2•17 years ago
|
||
Ah, true.
Assignee | ||
Comment 3•17 years ago
|
||
Calls reset, which calls DoSetRange with null/0 parameters.
Assignee | ||
Updated•17 years ago
|
Attachment #346658 -
Flags: approval1.9.1?
Assignee | ||
Comment 4•17 years ago
|
||
Note, this is needed for 1.9.1 for fix crasher bug 448993.
Assignee | ||
Comment 5•17 years ago
|
||
er, 'to fix', or something
Comment 6•17 years ago
|
||
Comment on attachment 346658 [details] [diff] [review]
v2
a191=beltzner
Attachment #346658 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [needs-1.9.1-landing]
Updated•17 years ago
|
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.1b3
Updated•12 years ago
|
Component: DOM: Traversal-Range → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•