Spinning off from bug 335998, this is simply a general leak fix that we should do.
Comment on attachment 346655 [details] [diff] [review] v1 >diff --git a/content/base/src/nsRange.cpp b/content/base/src/nsRange.cpp >+NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(nsRange) >+ NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mStartParent) >+ NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mEndParent) This needs to call DoSetRange, I think.
Calls reset, which calls DoSetRange with null/0 parameters.
Note, this is needed for 1.9.1 for fix crasher bug 448993.
er, 'to fix', or something
Comment on attachment 346658 [details] [diff] [review] v2 a191=beltzner
Attachment #346658 - Flags: approval1.9.1? → approval1.9.1+
Should this not block, as well?
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P2
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Fixed on trunk and 1.9.1
Target Milestone: --- → mozilla1.9.1b3
Component: DOM: Traversal-Range → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.