463458 - Remove used AIA certs after testing.

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Slavomir Katuscak]

In PKIX certificate chains tests (chains.sh) there are some certificates copied to external path (in our case NFS) to test AIA extension. Those certificates should be removed after testing is finished.

Comment 1

[Slavomir Katuscak]

Attachment: Patch.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Please provide a more detailed problem description.  
Why is cleaning up these files any more necessary than cleaning up any
of the other files generated during the test?

What problem is solved by the proposed patch?

Comment 3

[Slavomir Katuscak]

Christophe suggested this change, because all files used for AIA testing were copied to /share/builds/mccrel3/security/test and never removed. With time number of files there was increasing, so there is needed to do some cleanup.

Comment 4

[Christophe Ravel]

Comment on attachment 346697 [details] [diff] [review]
Patch.

r-=christophe

2 issues you need to fix:

Issue #1: what is "> ${AIA_FILES}" on line 672 ?

Issue #2: you need to delete the file AIA_FILES once you have deleted all the files that it lists. Otherwise you will try to delete non-existing files in the next test using AIA.

Comment 5

[Slavomir Katuscak]

(In reply to comment #4)
> Issue #1: what is "> ${AIA_FILES}" on line 672 ?

Creates empty file ${AIA_FILES} (most simple way how to do it in one step).

> Issue #2: you need to delete the file AIA_FILES once you have deleted all the
> files that it lists. Otherwise you will try to delete non-existing files in the
> next test using AIA.

As this file is empty, this problem would not happen. But I'm going to create patch to delete ${AIA_FILES} too.

Comment 6

[Slavomir Katuscak]

Attachment: Patch v2.

Addressed issue #2 from comment #5.

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

(In reply to comment #3)
> Christophe suggested this change, because all files used for AIA testing were
> copied to /share/builds/mccrel3/security/test and never removed. With time
> number of files there was increasing, so there is needed to do some cleanup.

What makes the storage requirements for these files different from the requirements for all the other files we create during a test run?

Why is it necessary to remove these files, and not all others also?

Comment 8

[Christophe Ravel]

These files are already kept in the test workspace. They are copied to this location to be available through a web server for the duration of the test. There is no need to keep them twice.

Comment 9

[Slavomir Katuscak]

Checking in chains.sh;
/cvsroot/mozilla/security/nss/tests/chains/chains.sh,v  <--  chains.sh
new revision: 1.2; previous revision: 1.1
done