Closed
Bug 463473
Opened 16 years ago
Closed 16 years ago
unescapeXML should also unescape numerical XML codes
Categories
(Webtools Graveyard :: Mozbot, defect)
Webtools Graveyard
Mozbot
Tracking
(Not tracked)
RESOLVED
FIXED
2.6
People
(Reporter: cww, Assigned: cww)
Details
(Whiteboard: [has-patch])
Attachments
(1 file)
|
778 bytes,
patch
|
wolf
:
review+
|
Details | Diff | Splinter Review |
Currently, the unescapeXML function only replaces a few known sequences (like ') with their counterparts. It does not handle things like '.
This has the result that doing some Google searches or other instances of pulling data from the internet, you end up with some escape sequences.
The patch replaces all &#(some number); sequences with the appropriate character in the range [32,126] inclusive. Higher numbered codes require some other fixes in terms of standardizing unicode support before landing and so are not handled in this bug.
Attachment #346722 -
Flags: review?(bugtrap)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 346722 [details] [diff] [review]
patch to unescapeXML
Looks good.
Attachment #346722 -
Flags: review?(bugtrap) → review+
|
|
||
Updated•16 years ago
|
Whiteboard: [has-patch]
|
|
||
Comment 2•16 years ago
|
||
Checking in mozbot.pl;
/cvsroot/mozilla/webtools/mozbot/mozbot.pl,v <-- mozbot.pl
new revision: 2.53; previous revision: 2.52
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Updated•16 years ago
|
Severity: normal → minor
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → 2.6
|
||
Updated•6 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•