463486 - Form history shouldn't remember the default values of unmodified fields.

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect)

Description

[Justin Dolske [:Dolske]]

Default/unmodified form field values shouldn't be remembered by form manager. If the user didn't enter the text, it seems odd to remember it. This may also help cut down the volume of form data that's remembered.

For example, take a form like:

<form action="http://example.com">
  <input name="name-A" value="value-A">
  <button type='submit'>Submit</button>
</form>

Submitting this (without changing the input's value) will add name-A/value-A to the form history.

Inputs have a .defaultValue property that we can check to see if the field was changed from the default value.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Simple change, added complete tests for what satchel does upon form submission (since there were none).

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 365717 [details] [diff] [review]
Patch v.1

>diff --git a/toolkit/components/satchel/test/test_form_submission.html b/toolkit/components/satchel/test/test_form_submission.html

>+    is(numSubmittedForms, 12, "Ensuring all forms were submitted.");;

;; o_O

Comment 3

[Justin Dolske [:Dolske]]

Comment on attachment 365717 [details] [diff] [review]
Patch v.1

I'd like to get this in 3.0.9 too, since it further helps reduce the volume of form history we store, and increment usage counts for form data the use isn't actually entering.

Comment 4

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/c7d82a90eca1

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 365717 [details] [diff] [review]
Patch v.1

a191=beltzner

Comment 6

[Justin Dolske [:Dolske]]

Pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/efe97b82cc91

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 365717 [details] [diff] [review]
Patch v.1

1.9.0.9 is in code-freeze (and was before we inserted FF3.0.8), moving request to next release.

Comment 8

[Samuel Sidler (old account; do not CC)]

Comment on attachment 365717 [details] [diff] [review]
Patch v.1

Hello, tests!

Approved for 1.9.0.10. a=ss

Comment 9

[Justin Dolske [:Dolske]]

Checked into 1.9.0.10:

Checking in toolkit/components/satchel/src/nsStorageFormHistory.cpp;
  new revision: 1.25; previous revision: 1.24
Checking in toolkit/components/satchel/test/test_form_submission.html;
  new revision: 1.2; previous revision: 1.1

Comment 10

[Al Billings [:abillings - ex-MoCo]]

Verified for 1.9.0.11.