463493 - path of x-moz-file flavour on linux is url-encoded

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Peter van Hardenberg]

Attachment: create an nsIFileURL instead and get the .file from that.

Dropping a file into a Mozilla application gets treated specially, creating an nsIFile object which can be accessed through the x-moz-file flavour.

Right now, this file's path is created by simply removing the "file://" substring from the beginning of the URL. This is only correct if the path does not contain any URL encoded characters.

See widget/gtk2/nsDragService.cpp:478 (or so).

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 346732 [details] [diff] [review]
create an nsIFileURL instead and get the .file from that.

+                            nsresult rv;
+                            nsCOMPtr<nsIIOService> ioService = do_GetIOService(&rv);
+                            nsCOMPtr<nsIURI> fileURI;
+                            rv = ioService->NewURI(NS_ConvertUTF16toUTF8(convertedText),

declare rv down where you assign it.

Fix that, attach a new patch, carry forward r+sr, then add the checkin-needed keyword to this bug. Thanks!!!

Comment 2

[Peter van Hardenberg]

Attachment: patch + nit fixed [Checkin: Comment 5]

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 346737 [details] [diff] [review]
patch + nit fixed
[Checkin: Comment 5]

We'll get this after beta 2.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 346737 [details] [diff] [review]
patch + nit fixed
[Checkin: Comment 5]

a191=beltzner

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 346737 [details] [diff] [review]
patch + nit fixed
[Checkin: Comment 5]

http://hg.mozilla.org/mozilla-central/rev/8174339ec32c

Please, provide a Hg patch next time.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9c6b1d59280d