Closed
Bug 463514
Opened 17 years ago
Closed 17 years ago
SNAV: Wrong comparison @_focusNextUsingCmdDispatcher()
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b3
People
(Reporter: tonikitoo, Assigned: tonikitoo)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file, 1 obsolete file)
|
916 bytes,
patch
|
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
In http://mxr.mozilla.org/mozilla-central/source/toolkit/spatial-navigation/SpatialNavigation.js#243 :
(..)
event.keyCode != PrefObserver['keyCodeDown']
(..)
should be
(..)
event.keyCode == PrefObserver['keyCodeDown']
(..)
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #346765 -
Flags: review?(doug.turner)
|
||
Updated•17 years ago
|
Attachment #346765 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
I just updated the patch #1 on top of changes in bug 463139 (they both change the same line). So it would have to be applied in sequence.
asking for 1.9.1 approval once it just fixes a wrong "==" in the code.
Attachment #346765 -
Attachment is obsolete: true
Attachment #349431 -
Flags: approval1.9.1?
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
||
Updated•17 years ago
|
Attachment #349431 -
Flags: approval1.9.1? → approval1.9.1+
|
|
||
Comment 3•17 years ago
|
||
Comment on attachment 349431 [details] [diff] [review]
simple fix (on top of changes in bug 463139)
[Checkin: Comment 4 & 5]
a191=beltzner
|
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [has patch][has review]
|
||
Comment 4•17 years ago
|
||
Comment on attachment 349431 [details] [diff] [review]
simple fix (on top of changes in bug 463139)
[Checkin: Comment 4 & 5]
http://hg.mozilla.org/mozilla-central/rev/d5fc7ddeb0d4
Attachment #349431 -
Attachment description: simple fix (on top of changes in bug 463139) → simple fix (on top of changes in bug 463139)
[Checkin: Comment 4]
|
|
||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review] → [c-n: baking for 1.9.1]
Target Milestone: --- → mozilla1.9.2a1
|
|
||
Comment 5•17 years ago
|
||
Comment on attachment 349431 [details] [diff] [review]
simple fix (on top of changes in bug 463139)
[Checkin: Comment 4 & 5]
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8232a57abecd
Attachment #349431 -
Attachment description: simple fix (on top of changes in bug 463139)
[Checkin: Comment 4] → simple fix (on top of changes in bug 463139)
[Checkin: Comment 4 & 5]
|
|
||
Updated•17 years ago
|
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [c-n: baking for 1.9.1]
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b3
|
||
Updated•7 years ago
|
Component: Keyboard: Navigation → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•