463538 - >230ms wasted on resize noops

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(dormant account)]

http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser-ui.js#450

There are 5 resize events called for w3.org to load. None of them actually changes any sizes.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I bet they are for other "windows". There is a check here:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/browser-ui.js#459

We could be getting "resize" event bubbles from the web page "window" and the iframe "windows" we use for the add-on manager and download manager.

Comment 2

[(dormant account)]

Attachment: guard against all resizes

I'm not sure if this logic change breaks anything because I don't know what the intent of the original separation of resize logic was.

Also why is popup_autocomplete's height modified on resize, but width isn't?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 347329 [details] [diff] [review]
guard against all resizes

hmm, I thought I tried this but saw weird issues with the panelUI. However, it seems ok now.

Comment 4

[(dormant account)]

pushed http://hg.mozilla.org/mobile-browser/rev/c6e107d1ce72

Comment 5

[Oleg Romashin (:romaxa)]

Looks like checkboxes disappears from preference tab after this commit.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

this code isn't in mxr, but we have refactored a lot of the resizing and browser code since this.