Closed
Bug 463561
Opened 14 years ago
Closed 14 years ago
mkdepend crashes while compiling freetype
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: blassey, Assigned: blassey)
Details
(Keywords: fixed1.9.1, mobile)
Attachments
(1 file, 1 obsolete file)
661 bytes,
patch
|
benjamin
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
It also crashes when compiling other sources that include freetype headers. For some reason we're dividing by zero when parsing some macros.
Assignee | ||
Comment 1•14 years ago
|
||
instead of dividing by zero, set the result to the largest integer it can hold
Attachment #346839 -
Flags: review?(benjamin)
Comment 2•14 years ago
|
||
What file is being compiled when mkdepend crashes? I'm a little leery of changing the mkdepend sources independently, since I'm pretty certain it is a straight import of external code (FreeBSD stuff, perhaps?)
Comment 3•14 years ago
|
||
CVS logs say it's from X11, but they also say we've taken local patches: http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/config/mkdepend/main.c&rev=HEAD&mark=3.7
Assignee | ||
Comment 4•14 years ago
|
||
It appears to crash anywhere ftconfig.h is included, while evaluating "FT_SIZEOF_INT (32 / FT_CHAR_BIT)." So there are two bugs here. First being FT_CHAR_BIT is defined to be 0, which is wrong. It appears to expect CHAR_BIT to be defined in <limits.h> /* `CHAR_BIT' (defined in limits.h) gives the number of bits in a */ /* `char' type. */ #ifndef FT_CHAR_BIT #define FT_CHAR_BIT CHAR_BIT #endif The second problem being that mkdepend crashes when it encounters this, giving no useful error message.
Comment 5•14 years ago
|
||
Comment on attachment 346839 [details] [diff] [review] fixes the crash Yeah, I don't think this is the right solution.
Attachment #346839 -
Flags: review?(benjamin) → review-
Comment 6•14 years ago
|
||
Without this patch (and just using the CHAR_BIT=8 patch in Makefile.in), i continue to crash when building cairo.
Assignee | ||
Updated•14 years ago
|
Attachment #346839 -
Flags: review- → review?(benjamin)
Assignee | ||
Comment 7•14 years ago
|
||
Comment on attachment 346839 [details] [diff] [review] fixes the crash Benjamin, what do you think the right solution is?
Comment 8•14 years ago
|
||
I think the right solution is for mkdepend to report an error if you try to divide by zero.
Assignee | ||
Comment 9•14 years ago
|
||
Attachment #346839 -
Attachment is obsolete: true
Attachment #358419 -
Flags: review?(benjamin)
Attachment #346839 -
Flags: review?(benjamin)
Updated•14 years ago
|
Attachment #358419 -
Flags: review?(benjamin) → review+
Comment 10•14 years ago
|
||
Comment on attachment 358419 [details] [diff] [review] throws an error for division by zero a191=beltzner
Attachment #358419 -
Flags: approval1.9.1+
Assignee | ||
Comment 11•14 years ago
|
||
pushed http://hg.mozilla.org/mozilla-central/rev/700fe6e76517
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•14 years ago
|
||
follow up push http://hg.mozilla.org/mozilla-central/rev/561fa10a7d71
Comment 13•13 years ago
|
||
Why hasn't this landed on branch yet?
Assignee | ||
Comment 14•13 years ago
|
||
pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b146d68c0718 and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/be85c97ff23f
Keywords: fixed1.9.1
Updated•4 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•