463561 - mkdepend crashes while compiling freetype

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

It also crashes when compiling other sources that include freetype headers.  For some reason we're dividing by zero when parsing some macros.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: fixes the crash

instead of dividing by zero, set the result to the largest integer it can hold

Comment 2

[Benjamin Smedberg]

What file is being compiled when mkdepend crashes? I'm a little leery of changing the mkdepend sources independently, since I'm pretty certain it is a straight import of external code (FreeBSD stuff, perhaps?)

Comment 3

[(not currently active) Ted Mielczarek]

CVS logs say it's from X11, but they also say we've taken local patches:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/config/mkdepend/main.c&rev=HEAD&mark=3.7

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

It appears to crash anywhere ftconfig.h is included, while evaluating "FT_SIZEOF_INT  (32 / FT_CHAR_BIT)."  So there are two bugs here.  First being FT_CHAR_BIT is defined to be 0, which is wrong.  It appears to expect CHAR_BIT to be defined in <limits.h>

  /* `CHAR_BIT' (defined in limits.h) gives the number of bits in a      */
  /* `char' type.                                                        */

#ifndef FT_CHAR_BIT
#define FT_CHAR_BIT  CHAR_BIT
#endif


The second problem being that mkdepend crashes when it encounters this, giving no useful error message.

Comment 5

[Benjamin Smedberg]

Comment on attachment 346839 [details] [diff] [review]
fixes the crash

Yeah, I don't think this is the right solution.

Comment 6

[Doug Turner (:dougt)]

Without this patch (and just using the CHAR_BIT=8 patch in Makefile.in), i continue to crash when building cairo.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 346839 [details] [diff] [review]
fixes the crash

Benjamin, what do you think the right solution is?

Comment 8

[Benjamin Smedberg]

I think the right solution is for mkdepend to report an error if you try to divide by zero.

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: throws an error for division by zero

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 358419 [details] [diff] [review]
throws an error for division by zero

a191=beltzner

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/700fe6e76517

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

follow up push http://hg.mozilla.org/mozilla-central/rev/561fa10a7d71

Comment 13

[Dão Gottwald [::dao]]

Why hasn't this landed on branch yet?

Comment 14

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b146d68c0718 and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/be85c97ff23f