463582 - Private browsing menu item does not work with no browser windows open

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Avram Lyon]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081106 Minefield/3.1b2pre
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081106 Minefield/3.1b2pre

When I have no browser windows open, the "Private Browsing" item in the Tools menu does nothing.

Reproducible: Always

Steps to Reproduce:
1. Enter private browsing mode.
2. Close all browser windows.
3. Select "Private Browsing" from the Tools menu.
Actual Results:  
No action.

Expected Results:  
The browser should restore what I had open before entering private browsing mode.

All it takes to leave private browsing mode is to open a window and use the menu item.

Comment 1

[(no longer active)]

Marcia: can you confirm this on a Mac?  If yes, can you please see if anything's logged on the console?

Comment 2

[Marcia Knous [:marcia]]

Confirming.  This is a two way problem that will hit the user - in the beginning if they close all browser windows and try to launch into PB nothing happens, and as the reporter notes when they try to exit PB mode the same issue will happenm since on the Mac it is possible to close the windows and still have the menu items show.

Comment 3

[(no longer active)]

Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ehsan, while doing the above steps I can see following entry within the Error Console:

Error: this._privateBrowsingService is null
Source File: chrome://browser/content/browser.js
Line: 8611

Probably that happen because we don't have any window which holds an instance? Ehsan, do you need more information to solve this problem?

With the given STR the feature cannot be used. Even that it will not happen as often, I'll ask for blocking1.9.1.

Comment 5

[(no longer active)]

(In reply to comment #4)
> Ehsan, while doing the above steps I can see following entry within the Error
> Console:
> 
> Error: this._privateBrowsingService is null
> Source File: chrome://browser/content/browser.js
> Line: 8611
> 
> Probably that happen because we don't have any window which holds an instance?
> Ehsan, do you need more information to solve this problem?

I guess it'd help if you can paste the exact lines on which it's failing from browser.js here.  But I think I know why this doesn't work, and how to fix it.  :-)

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sure. It's the last function (getter method) in browser.js:

  get privateBrowsingEnabled PBUI_get_privateBrowsingEnabled() {
=>  return this._privateBrowsingService.privateBrowsingEnabled;
  }

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Looks like gPrivateBrowsingUI.init() isn't being called in nonBrowserWindowDelayedStartup().

Comment 8

[(no longer active)]

Attachment: Patch (v1)

Init and uninit the PB UI object in Mac for cases with no window open.

Comment 9

[(no longer active)]

Landed on mozilla-central: <http://hg.mozilla.org/mozilla-central/rev/a32d4db772d2>

Comment 10

[Marcia Knous [:marcia]]

verified fixed on the trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090113 Minefield/3.2a1pre as well as the equivalent build on 10.4.11.  After closing the browser window, I can now stop the private browsing session from the Tools menu and resume where I left off.

Comment 11

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7458 added to Litmus.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

One remaining question. When I've started PB mode in a window-less mode I expect to also land there. Instead the former session is opened and the window with all tabs is displayed. Ehsan, is that really wanted?

Comment 13

[(no longer active)]

(In reply to comment #12)
> One remaining question. When I've started PB mode in a window-less mode I
> expect to also land there. Instead the former session is opened and the window
> with all tabs is displayed. Ehsan, is that really wanted?

Not really.  Can you please file a new bug on that?

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Done with bug 473429.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 355564 [details] [diff] [review]
Patch (v1)

a191=beltzner

Comment 16

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fe71edbb2925

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090115 Shiretoko/3.1b3pre Ubiquity/0.1.4 ID:20090115020658

Further I found a bug which shows inconsistent PB stats. I'll add it to the dependency list.