Closed Bug 463595 Opened 12 years ago Closed 12 years ago

browser_Application.js uses timeouts and fails intermittently

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.1b2

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Keywords: intermittent-failure, verified1.9.0.5)

Attachments

(1 file)

No description provided.
Assignee: nobody → dtownsend
Status: NEW → ASSIGNED
Attached patch patch rev 1Splinter Review
Use a proper window open listener to catch the console opening.
Attachment #346865 - Flags: review?(gavin.sharp)
Attachment #346865 - Flags: review?(gavin.sharp) → review+
Comment on attachment 346865 [details] [diff] [review]
patch rev 1

>diff --git a/browser/fuel/test/browser_Application.js b/browser/fuel/test/browser_Application.js

>+function WindowOpenListener(url, opencallback, closecallback) {

Perhaps we should add this helper to the harness?
(In reply to comment #2)
> (From update of attachment 346865 [details] [diff] [review])
> >diff --git a/browser/fuel/test/browser_Application.js b/browser/fuel/test/browser_Application.js
> 
> >+function WindowOpenListener(url, opencallback, closecallback) {
> 
> Perhaps we should add this helper to the harness?

Will look into that elsewhere but might be a good idea.
http://hg.mozilla.org/mozilla-central/rev/2e29c31b6a33

Thanks Dave!
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
I've checked this in on the 1.9.0 branch as well since it was being hit there fairly frequently on the linux boxes.

mozilla/browser/fuel/test/browser_Application.js 	1.4
Keywords: fixed1.9.0.5
Marking verified for 1.9.0.5 as I see that the test is passing.
Whiteboard: [orange]
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.