Create a pref to control the location bar search sources (history, bookmark, both, none)

RESOLVED FIXED in mozilla1.9.1b2

Status

()

Toolkit
Places
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

Trunk
mozilla1.9.1b2
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixes bug 463535)

Attachments

(1 attachment, 1 obsolete attachment)

9.94 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
This would map directly to the dropdown for the privacy prefpane without stealing/overriding/losing values of other preferences.
(Assignee)

Comment 1

9 years ago
Created attachment 346920 [details] [diff] [review]
v1

Create a pref with 4 states and tests to make sure it works.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #346920 - Flags: review?(dietrich)
Attachment #346920 - Flags: review?(dietrich) → review+
Comment on attachment 346920 [details] [diff] [review]
v1

r=me, with the dependency on bug 463459 removed. thanks, this is much clearer for users than the default.behavior pref.
(Assignee)

Comment 3

9 years ago
Created attachment 347012 [details] [diff] [review]
v1.1

Just use mRestrict* instead of SET_BEHAVIOR.
Attachment #346920 - Attachment is obsolete: true
(Assignee)

Comment 4

9 years ago
Comment on attachment 347012 [details] [diff] [review]
v1.1

This is needed for privacy prefpane bug 460343. Has tests too!
Attachment #347012 - Flags: approval1.9.1b2?
(Assignee)

Updated

9 years ago
No longer depends on: 463459
Flags: in-testsuite?
Target Milestone: --- → mozilla1.9.1b2
(Assignee)

Updated

9 years ago
Blocks: 463535
Whiteboard: fixes bug 463535
Depends on: 463459
Attachment #347012 - Flags: approval1.9.1b2? → approval1.9.1b2+
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/mozilla-central/rev/b77d8bd7903b
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
No longer depends on: 463459
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED

Comment 6

9 years ago
What parts, if any, of bug 447900 comment #3 does this obsolete? I fear we're running into some pref mess in the long term here...
(Assignee)

Comment 7

9 years ago
I was about to say bug 463459 would better cover the issue of empty == default behavior. But then reading bug 447900 comment 3, it seems like there's a desire to turn off the behavior entirely. (Bug 463459 provides a bitmap to turn on.. say, "match by title" by default; the default behavior is no filters.)

It kinda sounds like there should be a tri-state pref in addition to the filter-word pref:
1) always use this filter
2) use the filter if <filter-word> is used
3) never use this filter even if filter-word is used
If I am reading this bug correctly the new pref browser.urlbar.search.sources  does not include an option to only search tags. Is this intentional? The options seem to be bookmarks, history or both. Seeing as there is a filter pref browser.urlbar.restrict.tag does it not make sense to have a value for search.sources that defaults tags only?
Keywords: user-doc-needed

Updated

9 years ago
Keywords: user-doc-needed
You need to log in before you can comment on or make changes to this bug.