463679 - Two email notifications sent for cached CalDAV calendar

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Ludovic Marcotte]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.3) Gecko/2008092414 Firefox/3.0.3
Build Identifier: Lightning 0.9

When using cached CalDAV calendar, if one deletes an event that has an attendee, Lightning will either generate two IMIP messages or will issue two POST calls to the CalDAV server if CalDAV scheduling is enabled. Both cases will result in two emails being sent to the attendee. 

Reproducible: Always




The following code is the culprit one in calDavCalendar.js (from caldav_dDI_del_onStreamComplete) :

                   if (thisCalendar.isCached) {
                        // the item is deleted in the storage calendar from calCachedCalendar
                        realListener.onOperationComplete(thisCalendar, status,
                                                         Components.interfaces.calIOperationListener.DELETE,
                                                         null, null);
                    } else {
                        thisCalendar.mTargetCalendar.deleteItem(aItem, aListener);
                    }
                    thisCalendar.mTargetCalendar.deleteItem(aItem, aListener);


The last call to deleteItem(...) is unnecessary since it'll be done from calCachedCalendar for cached calendars.

Comment 1

[Simon Paquet [:sipaq]]

Ludovic, we're planning to do a release to accompany TB3 beta2 shortly. Any chance that you could provide a patch for this soon?

Comment 2

[Ludovic Marcotte]

Issue is still confirmed with the latest nightly builds (2009-02-22) of both Thunderbird 3 and Lightning.

Comment 3

[Ludovic Marcotte]

Attachment: Proposed fix

Comment 4

[Martin Schröder [:mschroeder]]

Comment on attachment 363567 [details] [diff] [review]
Proposed fix

Ludovic, please choose a reviewer next time. ;)

Comment 5

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 363567 [details] [diff] [review]
Proposed fix

I've tested this patch and it works fine for me, r=philipp

Comment 6

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/b9893abd4e80>

-> FIXED