Closed
Bug 463679
Opened 16 years ago
Closed 15 years ago
Two email notifications sent for cached CalDAV calendar
Categories
(Calendar :: Provider: CalDAV, defect)
Calendar
Provider: CalDAV
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: lmarcotte, Assigned: lmarcotte)
Details
(Whiteboard: [not needed beta][no l10n impact])
Attachments
(1 file)
561 bytes,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.3) Gecko/2008092414 Firefox/3.0.3 Build Identifier: Lightning 0.9 When using cached CalDAV calendar, if one deletes an event that has an attendee, Lightning will either generate two IMIP messages or will issue two POST calls to the CalDAV server if CalDAV scheduling is enabled. Both cases will result in two emails being sent to the attendee. Reproducible: Always The following code is the culprit one in calDavCalendar.js (from caldav_dDI_del_onStreamComplete) : if (thisCalendar.isCached) { // the item is deleted in the storage calendar from calCachedCalendar realListener.onOperationComplete(thisCalendar, status, Components.interfaces.calIOperationListener.DELETE, null, null); } else { thisCalendar.mTargetCalendar.deleteItem(aItem, aListener); } thisCalendar.mTargetCalendar.deleteItem(aItem, aListener); The last call to deleteItem(...) is unnecessary since it'll be done from calCachedCalendar for cached calendars.
Updated•16 years ago
|
Flags: blocking-calendar1.0?
Updated•16 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-calendar1.0? → blocking-calendar1.0+
Comment 1•15 years ago
|
||
Ludovic, we're planning to do a release to accompany TB3 beta2 shortly. Any chance that you could provide a patch for this soon?
Assignee: nobody → lmarcotte
Whiteboard: [needs patch for code in comment#0] → [needs patch for code in comment#0][not needed beta][no l10n impact]
Updated•15 years ago
|
Whiteboard: [needs patch for code in comment#0][not needed beta][no l10n impact] → [not needed beta][no l10n impact][needs patch for code in comment#0]
Assignee | ||
Comment 2•15 years ago
|
||
Issue is still confirmed with the latest nightly builds (2009-02-22) of both Thunderbird 3 and Lightning.
Assignee | ||
Comment 3•15 years ago
|
||
Updated•15 years ago
|
Keywords: qawanted
Whiteboard: [not needed beta][no l10n impact][needs patch for code in comment#0] → [not needed beta][no l10n impact]
Comment 4•15 years ago
|
||
Comment on attachment 363567 [details] [diff] [review] Proposed fix Ludovic, please choose a reviewer next time. ;)
Attachment #363567 -
Attachment is patch: true
Attachment #363567 -
Flags: review?(philipp)
Updated•15 years ago
|
Status: NEW → ASSIGNED
Comment 5•15 years ago
|
||
Comment on attachment 363567 [details] [diff] [review] Proposed fix I've tested this patch and it works fine for me, r=philipp
Attachment #363567 -
Flags: review?(philipp) → review+
Comment 6•15 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/b9893abd4e80> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Updated•14 years ago
|
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•