Closed
Bug 463687
Opened 17 years ago
Closed 16 years ago
"More info" on severity blocklist dialog doesnt do anything
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b3
People
(Reporter: tchung, Assigned: mossop)
References
Details
(Keywords: verified1.9.1)
Attachments
(3 files, 1 obsolete file)
More information screenshot
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081107 Minefield/3.1b2pre
Build Identifier:
The More information link on the severity blocklist dialog window links to nowhere. See screenshot
Reproducible: Always
Steps to Reproduce:
1. Launch trunk
2. set extensions.blocklist.url to the blocklist testcase to https://bugzilla.mozilla.org/attachment.cgi?id=346066
3. When blocklist kicks in, look for the blocklist dialog warning
4. Verify the "more information" link at the bottom goes nowhere
** See screenshot
Actual Results:
More info link goes to a page highlighting the blocklist navigates nowhere.
+<!ENTITY blocklist.moreinfo "More information">
Expected Results:
More info link goes to a page highlighting the blocklist navigates to a blocklist page.
|
Reporter | |
Comment 1•17 years ago
|
||
|
Assignee | |
Comment 2•17 years ago
|
||
Doesn't block b2 I think but we should fix this for final.
Assignee: nobody → dtownsend
Flags: blocking1.9.1+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Obviously I forgot to set this up.
Attachment #347256 -
Flags: review?(robert.bugzilla)
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 347256 [details] [diff] [review]
patch rev 1
Dave, do you want to add the workaround to honor tab browser settings while you're here?
|
|
Assignee | |
Comment 5•17 years ago
|
||
I considered that, but the issue I have is that the blocklist dialog is opened modal. I think if we honour tab browser settings then the url will open in a browser window that the user can't interact with which isn't very helpful.
|
|
||
Updated•17 years ago
|
Attachment #347256 -
Flags: review?(robert.bugzilla) → review+
|
|
Assignee | |
Comment 6•16 years ago
|
||
Patch for checkin
Attachment #347256 -
Attachment is obsolete: true
Attachment #350159 -
Flags: review+
|
||
Updated•16 years ago
|
Priority: -- → P2
|
|
||
Comment 7•16 years ago
|
||
|
||
Comment 8•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
|
||
Updated•16 years ago
|
Keywords: fixed1.9.1
|
|
Reporter | |
Comment 9•16 years ago
|
||
Verified fix on Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1b3pre) Gecko/20090212 Shiretoko/3.1b3pre
and Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090212 Minefield/3.2a1pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•