463745 - DOMLinkAdded event

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(dormant account)]

Attachment: rework favicon handling.

The time for this is proportional to the number of <link...href=">. Seems that many sites have 7 more of these elements which ends up using about 100ms of cpu time.

Maybe there is a way to do this using xpath, so we don't have to do a callback per <link/> element, but I don't know anything about that.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 346996 [details] [diff] [review]
rework favicon handling.

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js

>   _linkAdded : function(aEvent) {

>-    if (!link || !link.ownerDocument || !link.href)
>+    if (!link || !link.href || this._faviconLink )

Doesn't this mean we'll now use the first rather than the last? I don't think we want to change that.

Comment 2

[(dormant account)]

Good point. I'll take out "|| this._faviconLink".

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 346996 [details] [diff] [review]
rework favicon handling.

r+ with gavin's change

Comment 4

[(dormant account)]

pushed http://hg.mozilla.org/mobile-browser/rev/e3dbc2daf67f and http://hg.mozilla.org/mobile-browser/rev/c7fb9923d36b

Comment 5

[Anna (Waverley)]

Can someone please verify this, or provide some steps to reproduce ?