463882 - nsDownloadManager::Init is not safe for multiple calls

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

Bug 457110 made it possible to call nsDownloadManager::Init multiple times to switch the database engine.  Some parts of this method are not safe for multiple calls, for example switching the database can cause multiple copies of each observer being registered, which at best can waste memory and processing power, and at worst might manifest itself through other bugs.

The patch is simple enough.  We need to take this because any user who switches to/from the private browsing mode is going to trigger this.

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 347135 [details] [diff] [review]
Patch (v1)

I would be more inclined to make a new method that does the database switching work, and keep Init as it is.

Comment 2

[(no longer active)]

Attachment: Patch (v2)

OK, I did that in this patch.  I made sure that all the unit tests pass successfully with this patch applied.

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 348051 [details] [diff] [review]
Patch (v2)

hg generated a very unuseful patch there...

r=sdwilsh

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348051 [details] [diff] [review]
Patch (v2)

a191=beltzner

Comment 5

[(no longer active)]

Attachment: mq patch for check-in

Comment 6

[(no longer active)]

Attachment: mq patch for check-in

Comment 7

[Shawn Wilsher :sdwilsh]

Please make sure you attach a patch that has the username in it next time.  I almost pushed this as me.

http://hg.mozilla.org/mozilla-central/rev/73d9cfe0174c