463888 - Do not persist the "Save As" location in private browsing mode

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

From bug 248970 comment 513:

Ehsan: are we persisting the "Save As..." location?  I completely forgot about
that being something that we need to clear.

This patch prevents the browser.download.lastDir pref from being saved inside the private browsing mode.

Comment 1

[(no longer active)]

Comment on attachment 347138 [details] [diff] [review]
Patch (v1)

This would also be nice to take for Beta 2.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 347138 [details] [diff] [review]
Patch (v1)

We set this pref in helper dialog code too:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/src/nsHelperAppDlg.js.in#240

Seems like we should avoid that as well.

Comment 3

[(no longer active)]

Attachment: Patch (v1.1)

(In reply to comment #2)
> (From update of attachment 347138 [details] [diff] [review])
> We set this pref in helper dialog code too:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/src/nsHelperAppDlg.js.in#240
> 
> Seems like we should avoid that as well.

That's right.  The new patch handles this as well.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Making this a blocker, approval won't be needed.

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/a0f72d018c4a

Comment 6

[Ed Lee :Mardak]

So this change makes it not save the last saved directory instead of restoring it back to what it was before entering private browsing?

Seems like it would be annoying for those that download multiple files to the same directory in one private browsing session.

Comment 7

[(no longer active)]

(In reply to comment #6)
> So this change makes it not save the last saved directory instead of restoring
> it back to what it was before entering private browsing?
> 
> Seems like it would be annoying for those that download multiple files to the
> same directory in one private browsing session.

Hmmm, I agree.  Would you mind filing a follow-up bug and assigning it to me?  We can safely take that for the final release I suppose.

Comment 8

[(no longer active)]

Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.

Comment 9

[Marcia Knous [:marcia]]

Ehsan: I am trying to write a test case for this and I am having trouble understanding what was changed even after reading Comment 6. Can you help clarify what was changed here?

Also, was a follow up bug ever filed per your request in Comment 7?

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #9)
> Ehsan: I am trying to write a test case for this and I am having trouble
> understanding what was changed even after reading Comment 6. Can you help
> clarify what was changed here?

In previous versions before this patch was checked-in the download directory from the PB session was used after leaving it. So probably the following steps are necessary for a testcase:

1. Set "Always ask me where to save files" inside the preference window
2. Open http://www.google.de
3. Save the Google logo to disk and choose a directory
4. Enter PB mode
5. Navigate to http://www.google.de and save the same logo to another location
6. Leave PB mode
7. Try to save the logo again

You should see the folder from step 3 instead of the one from step 5.

> Also, was a follow up bug ever filed per your request in Comment 7?

Yes, it is already on the blocking list. It's bug 464795.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with the steps given in comment 10 and the following builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20081228 Shiretoko/3.1b3pre ID:20081228020322

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081228 Shiretoko/3.1b3pre ID:20081228032813

Comment 12

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7442 added to Litmus. Thanks to Henrik for scripting out the testcase, which I just made minor revisions to.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #7)
> (In reply to comment #6)
> > So this change makes it not save the last saved directory instead of restoring
> > it back to what it was before entering private browsing?
> > 
> > Seems like it would be annoying for those that download multiple files to the
> > same directory in one private browsing session.
> 
> Hmmm, I agree.  Would you mind filing a follow-up bug and assigning it to me? 
> We can safely take that for the final release I suppose.

Ehsan, had we ever a bug on that? I can see this behavior on Linux now. No idea if this is a recent regression. Do you have a bug # handy?

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry, missed bug 464795.

Comment 15

[(no longer active)]

The tests for this bug were added in bug 464795.