There is no privatebrowsing.xpt

RESOLVED FIXED in Firefox 3.1b2

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

({fixed1.9.1})

Trunk
Firefox 3.1b2
fixed1.9.1
Points:
---
Bug Flags:
blocking-firefox3.5 +
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 347202 [details] [diff] [review]
Fix

At the time of bug 248970 comment 223, there was a privatebrowsing.xpt which needed to be packaged, but around bug 248970 comment 327 it moved to netwerk, so now the interface is in some necko xpt, and the only remaining trace is a "possible missing or unnecessary file: bin/components/privatebrowsing.xpt" warning in the build log, which will shortly be making nthomas grind another layer of enamel off his teeth.
Attachment #347202 - Flags: review?(gavin.sharp)
Attachment #347202 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 1

10 years ago
Comment on attachment 347202 [details] [diff] [review]
Fix

Risk-free way to prevent a hapless build engineer from having to gum his food.
Attachment #347202 - Flags: approval1.9.1b2?

Comment 2

10 years ago
Oh, sorry for not catching this myself, and thanks for the patch, Phil!
Making this a blocker, doesn't need explicit approval,
Flags: blocking-firefox3.1+
Blocking on a build time warning? Beltzner must be getting soft... :)
(Assignee)

Comment 6

10 years ago
/me avoids the temptation to leave this open as his blocker on which to add all unrelated patches to skip approval
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.