463947 - There is no privatebrowsing.xpt

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix

At the time of bug 248970 comment 223, there was a privatebrowsing.xpt which needed to be packaged, but around bug 248970 comment 327 it moved to netwerk, so now the interface is in some necko xpt, and the only remaining trace is a "possible missing or unnecessary file: bin/components/privatebrowsing.xpt" warning in the build log, which will shortly be making nthomas grind another layer of enamel off his teeth.

Comment 1

[Phil Ringnalda (:philor)]

Comment on attachment 347202 [details] [diff] [review]
Fix

Risk-free way to prevent a hapless build engineer from having to gum his food.

Comment 2

[(no longer active)]

Oh, sorry for not catching this myself, and thanks for the patch, Phil!

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Making this a blocker, doesn't need explicit approval,

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Blocking on a build time warning? Beltzner must be getting soft... :)

Comment 5

[Dietrich Ayala (:dietrich)]

checked-in: http://hg.mozilla.org/mozilla-central/rev/52cbef37c00d

Comment 6

[Phil Ringnalda (:philor)]

/me avoids the temptation to leave this open as his blocker on which to add all unrelated patches to skip approval