Closed Bug 463947 Opened 11 years ago Closed 11 years ago

There is no privatebrowsing.xpt

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla3.1b2

People

(Reporter: philor, Assigned: philor)

Details

Attachments

(1 file)

Attached patch FixSplinter Review
At the time of bug 248970 comment 223, there was a privatebrowsing.xpt which needed to be packaged, but around bug 248970 comment 327 it moved to netwerk, so now the interface is in some necko xpt, and the only remaining trace is a "possible missing or unnecessary file: bin/components/privatebrowsing.xpt" warning in the build log, which will shortly be making nthomas grind another layer of enamel off his teeth.
Attachment #347202 - Flags: review?(gavin.sharp)
Attachment #347202 - Flags: review?(gavin.sharp) → review+
Comment on attachment 347202 [details] [diff] [review]
Fix

Risk-free way to prevent a hapless build engineer from having to gum his food.
Attachment #347202 - Flags: approval1.9.1b2?
Oh, sorry for not catching this myself, and thanks for the patch, Phil!
Making this a blocker, doesn't need explicit approval,
Flags: blocking-firefox3.1+
Blocking on a build time warning? Beltzner must be getting soft... :)
/me avoids the temptation to leave this open as his blocker on which to add all unrelated patches to skip approval
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b2
Component: Build Config → General
Product: Firefox → Firefox Build System
Keywords: fixed1.9.1
Target Milestone: Firefox 3.1b2 → mozilla3.1b2
You need to log in before you can comment on or make changes to this bug.